Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(488)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 207833003: Update screen.orientation to follow the latest version of the specs. (Closed)

Created:
6 years, 9 months ago by mlamouri (slow - plz ping)
Modified:
6 years, 9 months ago
Reviewers:
Inactive
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@partial_enum_callback
Visibility:
Public.

Description

Update screen.orientation to follow the latest version of the specs. It also returns 'portrait-primary' when the frame is detached instead of empty string (current behaviour). BUG=162827 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=169932

Patch Set 1 #

Patch Set 2 : tests update #

Patch Set 3 : forgot to update excepted #

Patch Set 4 : ... and mac expected results #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -13 lines) Patch
M LayoutTests/fast/dom/Window/property-access-on-cached-properties-after-frame-navigated-expected.txt View 1 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/dom/Window/property-access-on-cached-properties-after-frame-removed-and-gced-expected.txt View 1 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/dom/Window/property-access-on-cached-properties-after-frame-removed-expected.txt View 1 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/dom/Window/property-access-on-cached-window-after-frame-removed-and-gced-expected.txt View 1 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/dom/Window/property-access-on-cached-window-after-frame-removed-expected.txt View 1 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/dom/Window/resources/window-property-collector.js View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
M LayoutTests/platform/mac/fast/dom/Window/property-access-on-cached-properties-after-frame-navigated-expected.txt View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/platform/mac/fast/dom/Window/property-access-on-cached-properties-after-frame-removed-and-gced-expected.txt View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/platform/mac/fast/dom/Window/property-access-on-cached-properties-after-frame-removed-expected.txt View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/platform/mac/fast/dom/Window/property-access-on-cached-window-after-frame-removed-and-gced-expected.txt View 1 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/platform/mac/fast/dom/Window/property-access-on-cached-window-after-frame-removed-expected.txt View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/screen_orientation/ScreenOrientation.cpp View 1 chunk +4 lines, -2 lines 0 comments Download
M Source/modules/screen_orientation/ScreenOrientation.idl View 1 chunk +8 lines, -1 line 0 comments Download

Messages

Total messages: 42 (0 generated)
mlamouri (slow - plz ping)
I've deleted the previous CL by mistake when I wanted to add a comment saying ...
6 years, 9 months ago (2014-03-21 11:41:13 UTC) #1
Inactive
still lgtm
6 years, 9 months ago (2014-03-21 13:16:22 UTC) #2
mlamouri (slow - plz ping)
The CQ bit was checked by mlamouri@chromium.org
6 years, 9 months ago (2014-03-21 17:50:38 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mlamouri@chromium.org/207833003/1
6 years, 9 months ago (2014-03-21 17:50:47 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-21 18:27:05 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on linux_blink_rel
6 years, 9 months ago (2014-03-21 18:27:05 UTC) #6
mlamouri (slow - plz ping)
This is failing because there are actually already automated tests being ran when the frame ...
6 years, 9 months ago (2014-03-24 14:05:24 UTC) #7
mlamouri (slow - plz ping)
The CQ bit was checked by mlamouri@chromium.org
6 years, 9 months ago (2014-03-24 14:20:05 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mlamouri@chromium.org/207833003/20001
6 years, 9 months ago (2014-03-24 14:20:16 UTC) #9
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-24 14:52:40 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on linux_blink_rel
6 years, 9 months ago (2014-03-24 14:52:41 UTC) #11
mlamouri (slow - plz ping)
The CQ bit was checked by mlamouri@chromium.org
6 years, 9 months ago (2014-03-24 15:09:46 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mlamouri@chromium.org/207833003/40001
6 years, 9 months ago (2014-03-24 15:09:57 UTC) #13
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-24 15:45:03 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on mac_blink_rel
6 years, 9 months ago (2014-03-24 15:45:03 UTC) #15
mlamouri (slow - plz ping)
The CQ bit was checked by mlamouri@chromium.org
6 years, 9 months ago (2014-03-24 16:39:40 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mlamouri@chromium.org/207833003/60001
6 years, 9 months ago (2014-03-24 16:39:44 UTC) #17
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-24 16:41:00 UTC) #18
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on mac_blink_compile_dbg
6 years, 9 months ago (2014-03-24 16:41:01 UTC) #19
mlamouri (slow - plz ping)
The CQ bit was checked by mlamouri@chromium.org
6 years, 9 months ago (2014-03-24 17:11:02 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mlamouri@chromium.org/207833003/60001
6 years, 9 months ago (2014-03-24 17:11:09 UTC) #21
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-24 17:13:22 UTC) #22
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on mac_blink_rel
6 years, 9 months ago (2014-03-24 17:13:22 UTC) #23
mlamouri (slow - plz ping)
The CQ bit was checked by mlamouri@chromium.org
6 years, 9 months ago (2014-03-24 17:22:32 UTC) #24
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mlamouri@chromium.org/207833003/60001
6 years, 9 months ago (2014-03-24 17:22:33 UTC) #25
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-24 17:47:27 UTC) #26
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on win_blink_rel
6 years, 9 months ago (2014-03-24 17:47:28 UTC) #27
mlamouri (slow - plz ping)
The CQ bit was checked by mlamouri@chromium.org
6 years, 9 months ago (2014-03-24 17:49:06 UTC) #28
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mlamouri@chromium.org/207833003/60001
6 years, 9 months ago (2014-03-24 17:49:15 UTC) #29
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-24 17:51:33 UTC) #30
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on win_blink_rel
6 years, 9 months ago (2014-03-24 17:51:33 UTC) #31
mlamouri (slow - plz ping)
The CQ bit was checked by mlamouri@chromium.org
6 years, 9 months ago (2014-03-24 17:53:18 UTC) #32
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mlamouri@chromium.org/207833003/60001
6 years, 9 months ago (2014-03-24 17:53:24 UTC) #33
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-24 18:18:49 UTC) #34
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on mac_blink_rel
6 years, 9 months ago (2014-03-24 18:18:49 UTC) #35
mlamouri (slow - plz ping)
The CQ bit was checked by mlamouri@chromium.org
6 years, 9 months ago (2014-03-24 18:20:34 UTC) #36
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mlamouri@chromium.org/207833003/60001
6 years, 9 months ago (2014-03-24 18:20:45 UTC) #37
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-24 18:30:46 UTC) #38
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on win_blink_rel
6 years, 9 months ago (2014-03-24 18:30:46 UTC) #39
mlamouri (slow - plz ping)
The CQ bit was checked by mlamouri@chromium.org
6 years, 9 months ago (2014-03-25 11:03:03 UTC) #40
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mlamouri@chromium.org/207833003/60001
6 years, 9 months ago (2014-03-25 11:03:06 UTC) #41
commit-bot: I haz the power
6 years, 9 months ago (2014-03-25 11:40:21 UTC) #42
Message was sent while issue was closed. 
Change committed as 169932

Powered by Google App Engine
This is Rietveld 408576698