Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2078293002:
Add support for installing ARM64 sysroot (Closed)
DescriptionAdd support for installing ARM64 sysroot
This change modifies install-sysroot.py to add support for
installing ARM64 sysroot. Also update the jessie arm64 package list.
BUG=613452
Committed: https://crrev.com/ad891a49ee7aeff1a42559c0a059cb51f053e1fb
Cr-Commit-Position: refs/heads/master@{#404323}
Patch Set 1 #
Messages
Total messages: 22 (6 generated)
Description was changed from ========== Add support for installing ARM64 sysroot This change modifies install-sysroot.py to add support for installing ARM64 sysroot. also upadted jessie arm64 package list. BUG=613452 ========== to ========== Add support for installing ARM64 sysroot This change modifies install-sysroot.py to add support for installing ARM64 sysroot. also upadted jessie arm64 package list. BUG=613452 ==========
apatole@nvidia.com changed reviewers: + mmoss@chromium.org, thakis@chromium.org, thestig@chromium.org
On 2016/06/21 10:29:23, apatole wrote: > mailto:apatole@nvidia.com changed reviewers: > + mailto:mmoss@chromium.org, mailto:thakis@chromium.org, mailto:thestig@chromium.org Hi Reviewers, PTAL, I have modified scripts to install arm64 sysroot. But it needs sysroot to be uploaded first to google cloud. Please help me in creating/uploading it to cloud or let me know who can help. You can either create it or upload the one I shared at - https://drive.google.com/file/d/0B90Inl8Vlp2cb0hpV3dZVEpBNUk/view?usp=sharing. This patch uses sha1sum of the sysroot that I shared above. If we create it newly and upload, I will modify scripts to match its revision and sha1sum.
Description was changed from ========== Add support for installing ARM64 sysroot This change modifies install-sysroot.py to add support for installing ARM64 sysroot. also upadted jessie arm64 package list. BUG=613452 ========== to ========== Add support for installing ARM64 sysroot This change modifies install-sysroot.py to add support for installing ARM64 sysroot. Also update the jessie arm64 package list. BUG=613452 ==========
Post weekend ping for review :) ptal.
On 2016/06/27 06:55:47, apatole wrote: > Post weekend ping for review :) ptal. Sorry for the delay. Will look today.
Looks good, but I need to figure out how to upload the tarball. Once that's done, we can land this CL.
On 2016/06/28 00:35:36, Lei Zhang wrote: > Looks good, but I need to figure out how to upload the tarball. Once that's > done, we can land this CL. Sorry, this stuff came through while I was on vacation. Ping me tomorrow and I can help get the tarballs uploaded (it's likely the current trooper could also do it, if you want to go that route, but I'm not sure without looking at the bucket ACLs).
On 2016/07/01 00:17:04, Michael Moss wrote: > On 2016/06/28 00:35:36, Lei Zhang wrote: > > Looks good, but I need to figure out how to upload the tarball. Once that's > > done, we can land this CL. > > Sorry, this stuff came through while I was on vacation. Ping me tomorrow and I > can help get the tarballs uploaded (it's likely the current trooper could also > do it, if you want to go that route, but I'm not sure without looking at the > bucket ACLs). It's tomorrow. If you don't mind, please upload it. The sha1sum is in this CL.
On 2016/07/01 17:22:21, Lei Zhang wrote: > On 2016/07/01 00:17:04, Michael Moss wrote: > > On 2016/06/28 00:35:36, Lei Zhang wrote: > > > Looks good, but I need to figure out how to upload the tarball. Once that's > > > done, we can land this CL. > > > > Sorry, this stuff came through while I was on vacation. Ping me tomorrow and I > > can help get the tarballs uploaded (it's likely the current trooper could also > > do it, if you want to go that route, but I'm not sure without looking at the > > bucket ACLs). > > It's tomorrow. If you don't mind, please upload it. The sha1sum is in this CL. The tarball is now in gs://chrome-linux-sysroot/toolchain/bd10c315594d2a20e31a94a7a6c7adb9a0961c56/debian_jessie_arm64_sysroot.tgz. For future reference, it looks like you and sbc both have write access to that bucket, so you should be able to push new tarballs as well. Or if you want anyone else to be added, I think any Trooper should be able to modify ACLs.
On 2016/07/06 17:51:56, mmoss wrote: > On 2016/07/01 17:22:21, Lei Zhang wrote: > > On 2016/07/01 00:17:04, Michael Moss wrote: > > > On 2016/06/28 00:35:36, Lei Zhang wrote: > > > > Looks good, but I need to figure out how to upload the tarball. Once > that's > > > > done, we can land this CL. > > > > > > Sorry, this stuff came through while I was on vacation. Ping me tomorrow and > I > > > can help get the tarballs uploaded (it's likely the current trooper could > also > > > do it, if you want to go that route, but I'm not sure without looking at the > > > bucket ACLs). > > > > It's tomorrow. If you don't mind, please upload it. The sha1sum is in this CL. > > The tarball is now in > gs://chrome-linux-sysroot/toolchain/bd10c315594d2a20e31a94a7a6c7adb9a0961c56/debian_jessie_arm64_sysroot.tgz. > For future reference, it looks like you and sbc both have write access to that > bucket, so you should be able to push new tarballs as well. Or if you want > anyone else to be added, I think any Trooper should be able to modify ACLs. Thanks a lot Michael! Lie, I will try to test it once more and update just to make sure we are still able to build the latest source with this tar ball.
On 2016/07/07 06:15:09, apatole wrote: > On 2016/07/06 17:51:56, mmoss wrote: > > On 2016/07/01 17:22:21, Lei Zhang wrote: > > > On 2016/07/01 00:17:04, Michael Moss wrote: > > > > On 2016/06/28 00:35:36, Lei Zhang wrote: > > > > > Looks good, but I need to figure out how to upload the tarball. Once > > that's > > > > > done, we can land this CL. > > > > > > > > Sorry, this stuff came through while I was on vacation. Ping me tomorrow > and > > I > > > > can help get the tarballs uploaded (it's likely the current trooper could > > also > > > > do it, if you want to go that route, but I'm not sure without looking at > the > > > > bucket ACLs). > > > > > > It's tomorrow. If you don't mind, please upload it. The sha1sum is in this > CL. > > > > The tarball is now in > > > gs://chrome-linux-sysroot/toolchain/bd10c315594d2a20e31a94a7a6c7adb9a0961c56/debian_jessie_arm64_sysroot.tgz. > > For future reference, it looks like you and sbc both have write access to that > > bucket, so you should be able to push new tarballs as well. Or if you want > > anyone else to be added, I think any Trooper should be able to modify ACLs. > > Thanks a lot Michael! > > Lie, I will try to test it once more and update just to make sure we are still > able to build the latest source with this tar ball. Lie, I tested this patch with latest chromium source today. installsysroot.py --arch= arm64 and also gclient runhooks now installs arm64 sysroot. I was also able to do a release build of chrome using both GYP build as well as GN build. There are still some compilation errors in third_party/ffmpeg but I am not able to upload a patch for it, it is giving me some permission related errors. I have already attached the patch to the bug in comment #7. Let me know if you have any idea about how I can get this changes in. Please review/approve this patch. Let me also know if we can just commit this patch and then look at committing third_party/ffmpeg patch.
lgtm You keep typing my name wrong. :-P
On 2016/07/07 19:09:12, Lei Zhang wrote: > lgtm > > You keep typing my name wrong. :-P Thanks for the review and extremely sorry for the typo Lei, I did not notice it earlier.
The CQ bit was checked by apatole@nvidia.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Add support for installing ARM64 sysroot This change modifies install-sysroot.py to add support for installing ARM64 sysroot. Also update the jessie arm64 package list. BUG=613452 ========== to ========== Add support for installing ARM64 sysroot This change modifies install-sysroot.py to add support for installing ARM64 sysroot. Also update the jessie arm64 package list. BUG=613452 ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
CQ bit was unchecked.
Message was sent while issue was closed.
Description was changed from ========== Add support for installing ARM64 sysroot This change modifies install-sysroot.py to add support for installing ARM64 sysroot. Also update the jessie arm64 package list. BUG=613452 ========== to ========== Add support for installing ARM64 sysroot This change modifies install-sysroot.py to add support for installing ARM64 sysroot. Also update the jessie arm64 package list. BUG=613452 Committed: https://crrev.com/ad891a49ee7aeff1a42559c0a059cb51f053e1fb Cr-Commit-Position: refs/heads/master@{#404323} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/ad891a49ee7aeff1a42559c0a059cb51f053e1fb Cr-Commit-Position: refs/heads/master@{#404323}
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/2132153002/ by jbudorick@chromium.org. The reason for reverting is: https://bugs.chromium.org/p/chromium/issues/detail?id=626784. |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
