Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(412)

Issue 2078183002: [M52] add fail condition to addexpanded (Closed)

Created:
4 years, 6 months ago by f(malita)
Modified:
4 years, 6 months ago
Reviewers:
f(malita), caryclark
CC:
reviews_skia.org
Base URL:
https://chromium.googlesource.com/skia.git@m52
Target Ref:
refs/heads/chrome/m52
Project:
skia
Visibility:
Public.

Description

[M52] add fail condition to addexpanded (cherry-pick of 013e0e6d482f61181b829bf5ebfcad912c0061b1) If coincident pairs don't match, give up rather than deref null. TBR=fmalita@chromium.org,caryclark@google.com BUG=618991 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2058773002 Review-Url: https://codereview.chromium.org/2058773002 NOTREECHECKS=true NOTRY=true NOPRESUBMIT=true Committed: https://skia.googlesource.com/skia/+/d733ddceef018d5ec7d715b059cee05b5b3aa304

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -0 lines) Patch
M src/pathops/SkOpCoincidence.cpp View 1 chunk +3 lines, -0 lines 0 comments Download
M tests/PathOpsBuilderTest.cpp View 1 chunk +21 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (3 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2078183002/1
4 years, 6 months ago (2016-06-18 11:47:44 UTC) #3
commit-bot: I haz the power
4 years, 6 months ago (2016-06-18 11:47:58 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/d733ddceef018d5ec7d715b059cee05b5b3aa304

Powered by Google App Engine
This is Rietveld 408576698