Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(533)

Issue 2058773002: add fail condition to addexpanded (Closed)

Created:
4 years, 6 months ago by caryclark
Modified:
4 years, 6 months ago
Reviewers:
f(malita)
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

add fail condition to addexpanded If coincident pairs don't match, give up rather than deref null. R=fmalita@chromium.org BUG=618991 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2058773002 Committed: https://skia.googlesource.com/skia/+/013e0e6d482f61181b829bf5ebfcad912c0061b1

Patch Set 1 #

Patch Set 2 : remove debug change #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -0 lines) Patch
M src/pathops/SkOpCoincidence.cpp View 1 chunk +3 lines, -0 lines 0 comments Download
M tests/PathOpsBuilderTest.cpp View 1 chunk +21 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2058773002/20001
4 years, 6 months ago (2016-06-10 14:39:49 UTC) #3
caryclark
4 years, 6 months ago (2016-06-10 14:53:31 UTC) #4
f(malita)
lgtm
4 years, 6 months ago (2016-06-10 14:56:05 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 6 months ago (2016-06-10 14:58:17 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2058773002/20001
4 years, 6 months ago (2016-06-10 14:58:56 UTC) #9
commit-bot: I haz the power
4 years, 6 months ago (2016-06-10 14:59:53 UTC) #11
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/013e0e6d482f61181b829bf5ebfcad912c0061b1

Powered by Google App Engine
This is Rietveld 408576698