Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(635)

Issue 2077833002: Convert video-currentTime* tests to testharness.js. (Closed)

Created:
4 years, 6 months ago by Srirama
Modified:
4 years, 6 months ago
Reviewers:
fs, foolip
CC:
blink-reviews, chromium-reviews, eric.carlson_apple.com, feature-media-reviews_chromium.org, mlamouri+watch-blink_chromium.org, posciak+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Convert video-currentTime* tests to testharness.js. Cleaning up video-currentTime* tests in media/track to use testharness.js instead of video-test.js. This will enable to upstream these tests to web-platform-tests. BUG=588956 Committed: https://crrev.com/0cf2ffa8aaaa52e108e65809455f9985d5e333a4 Cr-Commit-Position: refs/heads/master@{#400631}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+58 lines, -82 lines) Patch
M third_party/WebKit/LayoutTests/media/video-currentTime.html View 1 chunk +21 lines, -15 lines 0 comments Download
D third_party/WebKit/LayoutTests/media/video-currentTime-expected.txt View 1 chunk +0 lines, -7 lines 0 comments Download
M third_party/WebKit/LayoutTests/media/video-currentTime-set.html View 1 chunk +19 lines, -26 lines 0 comments Download
D third_party/WebKit/LayoutTests/media/video-currentTime-set-expected.txt View 1 chunk +0 lines, -12 lines 0 comments Download
M third_party/WebKit/LayoutTests/media/video-currentTime-set2.html View 1 chunk +18 lines, -14 lines 0 comments Download
D third_party/WebKit/LayoutTests/media/video-currentTime-set2-expected.txt View 1 chunk +0 lines, -8 lines 0 comments Download

Messages

Total messages: 22 (11 generated)
Srirama
PTAL
4 years, 6 months ago (2016-06-17 07:34:54 UTC) #3
fs
lgtm
4 years, 6 months ago (2016-06-18 17:22:20 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2077833002/1
4 years, 6 months ago (2016-06-19 03:28:30 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/241373)
4 years, 6 months ago (2016-06-19 05:48:15 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2077833002/1
4 years, 6 months ago (2016-06-19 06:00:35 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/241388)
4 years, 6 months ago (2016-06-19 10:05:31 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2077833002/1
4 years, 6 months ago (2016-06-19 13:54:38 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/241394)
4 years, 6 months ago (2016-06-19 16:21:29 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2077833002/1
4 years, 6 months ago (2016-06-20 06:16:53 UTC) #18
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-20 07:27:23 UTC) #20
commit-bot: I haz the power
4 years, 6 months ago (2016-06-20 07:30:08 UTC) #22
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0cf2ffa8aaaa52e108e65809455f9985d5e333a4
Cr-Commit-Position: refs/heads/master@{#400631}

Powered by Google App Engine
This is Rietveld 408576698