Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Unified Diff: third_party/WebKit/LayoutTests/media/video-currentTime.html

Issue 2077833002: Convert video-currentTime* tests to testharness.js. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/media/video-currentTime-expected.txt » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/LayoutTests/media/video-currentTime.html
diff --git a/third_party/WebKit/LayoutTests/media/video-currentTime.html b/third_party/WebKit/LayoutTests/media/video-currentTime.html
index df46d6aa46dd0861b93f0729a0f72ec4de350b9a..b8b190c99c1911fca7045fdc0f50d8e67113f593 100644
--- a/third_party/WebKit/LayoutTests/media/video-currentTime.html
+++ b/third_party/WebKit/LayoutTests/media/video-currentTime.html
@@ -1,17 +1,23 @@
-<video controls></video>
-<script src=media-file.js></script>
-<!-- TODO(foolip): Convert test to testharness.js. crbug.com/588956
- (Please avoid writing new tests using video-test.js) -->
-<script src=video-test.js></script>
+<!DOCTYPE html>
+<title>Test media current time values.</title>
+<script src="../resources/testharness.js"></script>
+<script src="../resources/testharnessreport.js"></script>
+<script src="media-file.js"></script>
+<video></video>
<script>
- testExpected("video.currentTime", 0)
- waitForEvent('canplaythrough', function() { testExpected("video.currentTime", 0); } );
- video.addEventListener('canplaythrough', function() { video.play(); setTimeout(testCurrentTime, 500) });
- waitForEvent('play');
- function testCurrentTime()
- {
- testExpected("video.currentTime", 0, '>')
- endTest();
- }
+async_test(function(t) {
+ var video = document.querySelector("video");
+ assert_equals(video.currentTime, 0);
+
+ video.oncanplaythrough = t.step_func(function() {
+ assert_equals(video.currentTime, 0);
+ video.play();
+
+ setTimeout(t.step_func_done(function() {
+ assert_greater_than(video.currentTime, 0);
+ }), 500);
+ });
+
video.src = findMediaFile("video", "content/test");
-</script>
+});
+</script>
« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/media/video-currentTime-expected.txt » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698