Modify the ommnibox dropdown colors.

Modify the ommnibox dropdown colors.

* For all platforms: on selected lines, draw the icon using the text color
  rather than calling DeriveDefaultIconColor(), per comment 10 on the bug.
* For Windows: draw selected lines' URLs in white, like the text, instead of
  using GetReadableColor() on the URL color.  In MD, use the MD link blue for
  links instead of the old omnibox-specific green.

There are a few notes worth making.  I elected to make the "white icon" and
"white text" in non-MD as well because the changes are minor and arguably look
better (and it was easier, and non-MD is not very important anymore...).

Also, the Windows color selection code is careful about whether it uses
GetReadableColor() versus PickContrastingColor().  The idea of this is that the
unselected link color should be some kind of blue no matter what the window
backgruond, to indicate a link; so it uses GetReadableColor().  The hovered link
color should still be blue by default, so it can't use GetReadableColor() on the
white (lest it get black instead), but if the hover background happens to be
really dark, it's better to treat this "like selection" in the sense of using a
white URL than to use a light blue.  The selected link color has similar reasons
but in reverse: we want to be white in the default color scheme, but on systems
where the user has a light selection color on an otherwise dark background, it
seems better to use a blue link than a black one.  So in both cases we
PickContrastingColor() between white and blue, which should be a dark enough
color for these to be reasonable choices in most color schemes.

BUG=597754
TEST=On Windows, open the omnibox dropdown, and verify that URLs appear blue when not selected, and white when selected.

Committed: https://crrev.com/2a5551d69526ecc08d18c3983f085a94d179e95c
Cr-Commit-Position: refs/heads/master@{#400471}

[Peter Kasting, 2016-06-17 06:24:16]

pkasting@chromium.org changed reviewers:
+ estade@chromium.org

[Evan Stade, 2016-06-17 17:26:03]

lgtm

[Peter Kasting, 2016-06-17 18:46:43]

The CQ bit was checked by pkasting@chromium.org

[commit-bot: I haz the power, 2016-06-17 18:47:11]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2077803002/1

[commit-bot: I haz the power, 2016-06-17 18:52:15]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-06-17 18:54:02]

Description was changed from

==========
Modify the ommnibox dropdown colors.

* For all platforms: on selected lines, draw the icon using the text color
  rather than calling DeriveDefaultIconColor(), per comment 10 on the bug.
* For Windows: draw selected lines' URLs in white, like the text, instead of
  using GetReadableColor() on the URL color.  In MD, use the MD link blue for
  links instead of the old omnibox-specific green.

There are a few notes worth making.  I elected to make the "white icon" and
"white text" in non-MD as well because the changes are minor and arguably look
better (and it was easier, and non-MD is not very important anymore...).

Also, the Windows color selection code is careful about whether it uses
GetReadableColor() versus PickContrastingColor().  The idea of this is that the
unselected link color should be some kind of blue no matter what the window
backgruond, to indicate a link; so it uses GetReadableColor().  The hovered link
color should still be blue by default, so it can't use GetReadableColor() on the
white (lest it get black instead), but if the hover background happens to be
really dark, it's better to treat this "like selection" in the sense of using a
white URL than to use a light blue.  The selected link color has similar reasons
but in reverse: we want to be white in the default color scheme, but on systems
where the user has a light selection color on an otherwise dark background, it
seems better to use a blue link than a black one.  So in both cases we
PickContrastingColor() between white and blue, which should be a dark enough
color for these to be reasonable choices in most color schemes.

BUG=597754
TEST=On Windows, open the omnibox dropdown, and verify that URLs appear blue
when not selected, and white when selected.
==========

to

==========
Modify the ommnibox dropdown colors.

* For all platforms: on selected lines, draw the icon using the text color
  rather than calling DeriveDefaultIconColor(), per comment 10 on the bug.
* For Windows: draw selected lines' URLs in white, like the text, instead of
  using GetReadableColor() on the URL color.  In MD, use the MD link blue for
  links instead of the old omnibox-specific green.

There are a few notes worth making.  I elected to make the "white icon" and
"white text" in non-MD as well because the changes are minor and arguably look
better (and it was easier, and non-MD is not very important anymore...).

Also, the Windows color selection code is careful about whether it uses
GetReadableColor() versus PickContrastingColor().  The idea of this is that the
unselected link color should be some kind of blue no matter what the window
backgruond, to indicate a link; so it uses GetReadableColor().  The hovered link
color should still be blue by default, so it can't use GetReadableColor() on the
white (lest it get black instead), but if the hover background happens to be
really dark, it's better to treat this "like selection" in the sense of using a
white URL than to use a light blue.  The selected link color has similar reasons
but in reverse: we want to be white in the default color scheme, but on systems
where the user has a light selection color on an otherwise dark background, it
seems better to use a blue link than a black one.  So in both cases we
PickContrastingColor() between white and blue, which should be a dark enough
color for these to be reasonable choices in most color schemes.

BUG=597754
TEST=On Windows, open the omnibox dropdown, and verify that URLs appear blue
when not selected, and white when selected.

Committed: https://crrev.com/2a5551d69526ecc08d18c3983f085a94d179e95c
Cr-Commit-Position: refs/heads/master@{#400471}
==========

[commit-bot: I haz the power, 2016-06-17 18:54:03]

Patchset 1 (id:??) landed as
https://crrev.com/2a5551d69526ecc08d18c3983f085a94d179e95c
Cr-Commit-Position: refs/heads/master@{#400471}