Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(118)

Issue 2076893002: Theme code cleanup. (Closed)

Created:
4 years, 6 months ago by Peter Kasting
Modified:
4 years, 6 months ago
Reviewers:
Evan Stade
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Theme code cleanup. * Remove some color constants that are never used. * Remove some MD-specific constants in the Aura theme that are exactly the same as the non-MD constants. * Pull pre-MD-specific cases out of the Windows code to avoid repeated conditional breaks. * Rename/reorder Windows constants a bit in preparation for changing how MD works. BUG=597754 TEST=none Committed: https://crrev.com/9b55ff2e61b462dfb0c9b2ee86d43ea26df9a135 Cr-Commit-Position: refs/heads/master@{#400453}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -54 lines) Patch
M chrome/browser/ui/libgtk2ui/native_theme_gtk2.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M ui/native_theme/common_theme.cc View 7 chunks +3 lines, -24 lines 0 comments Download
M ui/native_theme/native_theme.h View 1 chunk +0 lines, -3 lines 0 comments Download
M ui/native_theme/native_theme_dark_aura.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M ui/native_theme/native_theme_win.cc View 4 chunks +24 lines, -21 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 8 (3 generated)
Peter Kasting
4 years, 6 months ago (2016-06-17 06:10:17 UTC) #2
Evan Stade
lgtm
4 years, 6 months ago (2016-06-17 17:28:39 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2076893002/1
4 years, 6 months ago (2016-06-17 17:57:49 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-17 18:03:01 UTC) #6
commit-bot: I haz the power
4 years, 6 months ago (2016-06-17 18:04:55 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9b55ff2e61b462dfb0c9b2ee86d43ea26df9a135
Cr-Commit-Position: refs/heads/master@{#400453}

Powered by Google App Engine
This is Rietveld 408576698