Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(860)

Unified Diff: ui/base/ime/input_method_base.h

Issue 2077783002: Make limitations for input.ime.sendKeyEvents API. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressed Devlin's comments. Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/base/ime/input_method_base.h
diff --git a/ui/base/ime/input_method_base.h b/ui/base/ime/input_method_base.h
index 3a44e37f0ece9239278d04e482b222325ba628da..ddc960c5969a197deb9d73eba03d99d97f408225 100644
--- a/ui/base/ime/input_method_base.h
+++ b/ui/base/ime/input_method_base.h
@@ -70,6 +70,7 @@ class UI_BASE_IME_EXPORT InputMethodBase
bool visible) override;
void DeleteSurroundingText(int32_t offset, uint32_t length) override;
void SendKeyEvent(KeyEvent* event) override;
+ InputMethod* GetInputMethod() override;
// Sends a fake key event for IME composing without physical key events.
// Returns true if the faked key event is stopped propagation.
@@ -108,6 +109,9 @@ class UI_BASE_IME_EXPORT InputMethodBase
bool sending_key_event_;
private:
+ // InputMethod:
+ const ScopedVector<ui::KeyEvent>& GetKeyEventsForTesting() override;
+
void SetFocusedTextInputClientInternal(TextInputClient* client);
internal::InputMethodDelegate* delegate_;
@@ -115,6 +119,8 @@ class UI_BASE_IME_EXPORT InputMethodBase
base::ObserverList<InputMethodObserver> observer_list_;
+ ScopedVector<ui::KeyEvent> key_events_for_testing_;
+
DISALLOW_COPY_AND_ASSIGN(InputMethodBase);
};

Powered by Google App Engine
This is Rietveld 408576698