Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(643)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: ui/base/ime/input_method_base.cc

Issue 2077783002: Make limitations for input.ime.sendKeyEvents API. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressed Devlin's comments. Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« chrome/test/data/extensions/api_test/input_ime_nonchromeos/background.js ('K') | « ui/base/ime/input_method_base.h ('k') | ui/base/ime/mock_input_method.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/base/ime/input_method_base.cc
diff --git a/ui/base/ime/input_method_base.cc b/ui/base/ime/input_method_base.cc
index 282b6c4f9ad5434ab6eef5d541eea02a8245d12b..6a850a7cf696155f6b46fdd70eddfc52403c5cd6 100644
--- a/ui/base/ime/input_method_base.cc
+++ b/ui/base/ime/input_method_base.cc
@@ -199,8 +199,19 @@ void InputMethodBase::DeleteSurroundingText(int32_t offset, uint32_t length) {}
void InputMethodBase::SendKeyEvent(KeyEvent* event) {
sending_key_event_ = true;
+ if (track_key_events_for_testing_) {
+ key_events_for_testing_.push_back(new KeyEvent(*event));
+ }
DispatchKeyEvent(event);
sending_key_event_ = false;
}
+InputMethod* InputMethodBase::GetInputMethod() {
+ return this;
+}
+
+const ScopedVector<ui::KeyEvent>& InputMethodBase::GetKeyEventsForTesting() {
Devlin 2016/06/28 20:56:44 (same comment about ScopedVector)
Azure Wei 2016/06/29 02:53:46 Done.
+ return key_events_for_testing_;
+}
+
} // namespace ui
« chrome/test/data/extensions/api_test/input_ime_nonchromeos/background.js ('K') | « ui/base/ime/input_method_base.h ('k') | ui/base/ime/mock_input_method.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698