Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(109)

Issue 2077743004: [Mac][Material Design] Adjust cutoff for detecting a "dark" theme. (Closed)

Created:
4 years, 6 months ago by shrike
Modified:
4 years, 6 months ago
Reviewers:
tapted
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2743
Target Ref:
refs/pending/branch-heads/2743
Project:
chromium
Visibility:
Public.

Description

[Mac][Material Design] Adjust cutoff for detecting a "dark" theme. Chrome looks at the whiteComponent of a theme's custom toolbar color to decide if the theme is "dark." The line between ligth and dark is an empirical value - this cl adjusts the cutoff in hopes of getting closer to the right value. R=tapted@chromium.org BUG=614806, 617993 Review-Url: https://codereview.chromium.org/2068243002 Cr-Commit-Position: refs/heads/master@{#400168} (cherry picked from commit f4acec7a4f8fe1e3e50785a7a601499c2f7619b5) Committed: https://chromium.googlesource.com/chromium/src/+/75175ca5f6abba3c5d15cbbc1080ce8f5889a946

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -2 lines) Patch
M chrome/browser/ui/cocoa/chrome_browser_window.mm View 3 chunks +12 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
shrike
4 years, 6 months ago (2016-06-17 22:13:31 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
75175ca5f6abba3c5d15cbbc1080ce8f5889a946.

Powered by Google App Engine
This is Rietveld 408576698