[Mac][Material Design] Adjust cutoff for detecting a "dark" theme.

[Mac][Material Design] Adjust cutoff for detecting a "dark" theme.

Chrome looks at the whiteComponent of a theme's custom toolbar color to
decide if the theme is "dark." The line between ligth and dark is an
empirical value - this cl adjusts the cutoff in hopes of getting closer
to the right value.

R=tapted@chromium.org
BUG=614806, 617993
Committed: https://crrev.com/f4acec7a4f8fe1e3e50785a7a601499c2f7619b5
Cr-Commit-Position: refs/heads/master@{#400168}

[shrike, 2016-06-15 17:11:28]

PTAL

[shrike, 2016-06-15 21:22:56]

Description was changed from

==========
[Mac][Material Design] Adjust cutoff for detecting a "dark" theme.

Chrome looks at the whiteComponent of a theme's custom toolbar color to
decide if the theme is "dark." The line between ligth and dark is an
empirical value - this cl adjusts the cutoff in hopes of getting closer
to the right value.

R=tapted@chromium.org
BUG=614806
==========

to

==========
[Mac][Material Design] Adjust cutoff for detecting a "dark" theme.

Chrome looks at the whiteComponent of a theme's custom toolbar color to
decide if the theme is "dark." The line between ligth and dark is an
empirical value - this cl adjusts the cutoff in hopes of getting closer
to the right value.

R=tapted@chromium.org
BUG=614806,617993
==========

[tapted, 2016-06-16 00:45:03]

lgtm with a constant

https://codereview.chromium.org/2068243002/diff/1/chrome/browser/ui/cocoa/chr...
File chrome/browser/ui/cocoa/chrome_browser_window.mm (right):

https://codereview.chromium.org/2068243002/diff/1/chrome/browser/ui/cocoa/chr...
chrome/browser/ui/cocoa/chrome_browser_window.mm:80: return [theColor
whiteComponent] >= 0.7;
does this need to be changed too?

but also these magic numbers should be at the top of the file. E.g.

// Empirically determined constants for deciding whether a theme is "dark". A
darker background color, or a lighter foreground color than these values will
classify a theme as dark.
const CGFloat kDarkBackgroundUpperBound = 0.55;
const CGFloat kDarkForegroundLowerBound = 0.7;

(or a single constant, if it makes sense to keep them the same).

[shrike, 2016-06-16 15:44:15]

The CQ bit was checked by shrike@chromium.org

[shrike, 2016-06-16 15:44:15]

The patchset sent to the CQ was uploaded after l-g-t-m from tapted@chromium.org
Link to the patchset: https://codereview.chromium.org/2068243002/#ps20001
(title: "Fix nits.")

[commit-bot: I haz the power, 2016-06-16 15:44:57]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2068243002/20001

[commit-bot: I haz the power, 2016-06-16 16:24:58]

Description was changed from

==========
[Mac][Material Design] Adjust cutoff for detecting a "dark" theme.

Chrome looks at the whiteComponent of a theme's custom toolbar color to
decide if the theme is "dark." The line between ligth and dark is an
empirical value - this cl adjusts the cutoff in hopes of getting closer
to the right value.

R=tapted@chromium.org
BUG=614806,617993
==========

to

==========
[Mac][Material Design] Adjust cutoff for detecting a "dark" theme.

Chrome looks at the whiteComponent of a theme's custom toolbar color to
decide if the theme is "dark." The line between ligth and dark is an
empirical value - this cl adjusts the cutoff in hopes of getting closer
to the right value.

R=tapted@chromium.org
BUG=614806,617993
==========

[commit-bot: I haz the power, 2016-06-16 16:24:58]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-06-16 16:25:21]

CQ bit was unchecked

[commit-bot: I haz the power, 2016-06-16 16:26:41]

Description was changed from

==========
[Mac][Material Design] Adjust cutoff for detecting a "dark" theme.

Chrome looks at the whiteComponent of a theme's custom toolbar color to
decide if the theme is "dark." The line between ligth and dark is an
empirical value - this cl adjusts the cutoff in hopes of getting closer
to the right value.

R=tapted@chromium.org
BUG=614806,617993
==========

to

==========
[Mac][Material Design] Adjust cutoff for detecting a "dark" theme.

Chrome looks at the whiteComponent of a theme's custom toolbar color to
decide if the theme is "dark." The line between ligth and dark is an
empirical value - this cl adjusts the cutoff in hopes of getting closer
to the right value.

R=tapted@chromium.org
BUG=614806,617993

Committed: https://crrev.com/f4acec7a4f8fe1e3e50785a7a601499c2f7619b5
Cr-Commit-Position: refs/heads/master@{#400168}
==========

[commit-bot: I haz the power, 2016-06-16 16:26:42]

Patchset 2 (id:??) landed as
https://crrev.com/f4acec7a4f8fe1e3e50785a7a601499c2f7619b5
Cr-Commit-Position: refs/heads/master@{#400168}

[shrike, 2016-06-16 22:50:46]

https://codereview.chromium.org/2068243002/diff/1/chrome/browser/ui/cocoa/chr...
File chrome/browser/ui/cocoa/chrome_browser_window.mm (right):

https://codereview.chromium.org/2068243002/diff/1/chrome/browser/ui/cocoa/chr...
chrome/browser/ui/cocoa/chrome_browser_window.mm:80: return [theColor
whiteComponent] >= 0.7;
On 2016/06/16 00:45:03, tapted wrote:
> does this need to be changed too?
> 
> but also these magic numbers should be at the top of the file. E.g.
> 
> // Empirically determined constants for deciding whether a theme is "dark". A
> darker background color, or a lighter foreground color than these values will
> classify a theme as dark.
> const CGFloat kDarkBackgroundUpperBound = 0.55;
> const CGFloat kDarkForegroundLowerBound = 0.7;
> 
> (or a single constant, if it makes sense to keep them the same).

Thank you. And there need to be two numbers because I believe the threshold for
labeling text as being dark is different than that of a background.