Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(91)

Issue 2077463002: Call pp::Size::IsEmpty() instead of !pp::Size::GetArea(). (Closed)

Created:
4 years, 6 months ago by Lei Zhang
Modified:
4 years, 6 months ago
Reviewers:
raymes
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Call pp::Size::IsEmpty() instead of !pp::Size::GetArea(). The codes does not actually care about the area. BUG=617607 Committed: https://crrev.com/cffe08d8656fc2ec9fafa09d51b7f3f9a67b1a3f Cr-Commit-Position: refs/heads/master@{#400083}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M pdf/out_of_process_instance.cc View 1 chunk +1 line, -1 line 0 comments Download
M pdf/pdfium/pdfium_engine.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (5 generated)
Lei Zhang
4 years, 6 months ago (2016-06-16 02:14:05 UTC) #2
raymes
lgtm but I think the bug number should be 617607
4 years, 6 months ago (2016-06-16 03:54:32 UTC) #3
Lei Zhang
On 2016/06/16 03:54:32, raymes wrote: > lgtm but I think the bug number should be ...
4 years, 6 months ago (2016-06-16 03:55:47 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2077463002/1
4 years, 6 months ago (2016-06-16 03:56:18 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-16 04:13:35 UTC) #9
commit-bot: I haz the power
CQ bit was unchecked
4 years, 6 months ago (2016-06-16 04:13:36 UTC) #10
commit-bot: I haz the power
4 years, 6 months ago (2016-06-16 04:15:49 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/cffe08d8656fc2ec9fafa09d51b7f3f9a67b1a3f
Cr-Commit-Position: refs/heads/master@{#400083}

Powered by Google App Engine
This is Rietveld 408576698