pdf/pdfium/pdfium_engine.cc - Issue 2077463002: Call pp::Size::IsEmpty() instead of !pp::Size::GetArea().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pdf/pdfium/pdfium_engine.cc

Issue 2077463002: Call pp::Size::IsEmpty() instead of !pp::Size::GetArea(). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: pdf/pdfium/pdfium_engine.cc

diff --git a/pdf/pdfium/pdfium_engine.cc b/pdf/pdfium/pdfium_engine.cc

index 17ef03f6a74428bc7d918c7b84c373affcdc221e..adc743c78ec8f8e5461bf720043d331ea3cc7a00 100644

--- a/pdf/pdfium/pdfium_engine.cc

+++ b/pdf/pdfium/pdfium_engine.cc

@@ -2671,7 +2671,7 @@ bool PDFiumEngine::CheckPageAvailable(int index, std::vector<int>* pending) {

if (index < num_pages)

pages_[index]->set_available(true);

- if (!default_page_size_.GetArea())

+ if (default_page_size_.IsEmpty())

default_page_size_ = GetPageSize(index);

return true;

}

« no previous file with comments | « pdf/out_of_process_instance.cc ('k') | no next file » | no next file with comments »