Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(510)

Issue 2077353006: Fix Mac clang linker (Closed)

Created:
4 years, 6 months ago by msarett
Modified:
4 years, 6 months ago
Reviewers:
scroggo, Brian Osman
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : Better description #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -2 lines) Patch
M bench/nanobench.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M dm/DM.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M tools/flags/SkCommonFlags.h View 1 chunk +1 line, -0 lines 0 comments Download
M tools/flags/SkCommonFlags.cpp View 1 1 chunk +5 lines, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 12 (6 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2077353006/1
4 years, 6 months ago (2016-06-21 16:12:12 UTC) #3
msarett
4 years, 6 months ago (2016-06-21 16:12:57 UTC) #5
scroggo
lgtm https://codereview.chromium.org/2077353006/diff/1/tools/flags/SkCommonFlags.cpp File tools/flags/SkCommonFlags.cpp (right): https://codereview.chromium.org/2077353006/diff/1/tools/flags/SkCommonFlags.cpp#newcode24 tools/flags/SkCommonFlags.cpp:24: DEFINE_bool(simpleCodec, false, "Runs of a subset of the ...
4 years, 6 months ago (2016-06-21 16:16:18 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2077353006/20001
4 years, 6 months ago (2016-06-21 16:27:02 UTC) #9
msarett
https://codereview.chromium.org/2077353006/diff/1/tools/flags/SkCommonFlags.cpp File tools/flags/SkCommonFlags.cpp (right): https://codereview.chromium.org/2077353006/diff/1/tools/flags/SkCommonFlags.cpp#newcode24 tools/flags/SkCommonFlags.cpp:24: DEFINE_bool(simpleCodec, false, "Runs of a subset of the codec ...
4 years, 6 months ago (2016-06-21 16:27:17 UTC) #10
commit-bot: I haz the power
4 years, 6 months ago (2016-06-21 16:44:32 UTC) #12
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/db197a54b562d92a9da2f849e780aa327e1991ca

Powered by Google App Engine
This is Rietveld 408576698