Improve performance to remove OPTIONs from a single-selection SELECT.

Improve performance to remove OPTIONs from a single-selection SELECT.

LayoutMenuList::updateOptionsHeightWidth() is an O(n) function to get maximum
OPTION width and height.

We had a bad performance because it is called whenever we remove a selected
OPTION from a SELECT. This CL changes the timing of updateOptionsHeightWidth().

Old:
  It was called by updateFromElement() after an OPTION is
  added/removed. updateOptionsHeightWidth() makes layout dirty only if maximum
  width/height was changed.

New:
  OPTION addition/removal makes maximum width/height dirty and makes layout
  dirty, and updateOptionsHeightWidth() is called only if the maximum
  width/height is referred.

The new behavior makes layout dirty more frequently, however it reduces the
number of updateOptionsHeightWidth() calls significantly.

This CL makes PerformanceTests/DOM/select-single-remove.html faster.
On my local machine, 5.1 runs/s -> 45.1 runs/s

Test update:
* http/tests/webfont/popup-menu-load-webfont-after-open.html
  LayoutMenuList correctly updates its width and height after this CL.
* fast/repaint/control-clip.html
  Extra invalidation as expected.

BUG=620142
Committed: https://crrev.com/1b32ab54ae3451e24152fc1e433b7e1cb44ac56e
Cr-Commit-Position: refs/heads/master@{#400903}

[tkent, 2016-06-20 08:28:05]

Patchset #1 (id:1) has been deleted

[tkent, 2016-06-20 08:29:45]

Description was changed from

==========
Improve performance to remove OPTIONs from a single-selection SELECT.

LayoutMenuList::updateOptionsHeightWidth() is a O(n) function to get maximum
OPTION width and height.

We had a bad performance because it is called whenever we remove a selected
OPTION from a SELECT. This CL changes the timing of updateOptionsHeightWidth().

Old:
  It was called by updateFromElement() after an OPTION is
  added/removed. updateOptionsHeightWidth() makes layout dirty only if maximum
  width/height was changed.

New:
  OPTION addition/removal makes maximum width/height dirty and makes layout
  dirty, and updateOptionsHeightWidth() is called only if the maximum
  width/height is referred.

The new behavior makes layout dirty more frequently, however it reduces the
number of updateOptionsHeightWidth() calls significantly.

This CL make PerformanceTests/DOM/select-single-remove.html faster.
On my local machine, 5.1 runs/s -> 45.1 runs/s

BUG=620142
==========

to

==========
Improve performance to remove OPTIONs from a single-selection SELECT.

LayoutMenuList::updateOptionsHeightWidth() is a O(n) function to get maximum
OPTION width and height.

We had a bad performance because it is called whenever we remove a selected
OPTION from a SELECT. This CL changes the timing of updateOptionsHeightWidth().

Old:
  It was called by updateFromElement() after an OPTION is
  added/removed. updateOptionsHeightWidth() makes layout dirty only if maximum
  width/height was changed.

New:
  OPTION addition/removal makes maximum width/height dirty and makes layout
  dirty, and updateOptionsHeightWidth() is called only if the maximum
  width/height is referred.

The new behavior makes layout dirty more frequently, however it reduces the
number of updateOptionsHeightWidth() calls significantly.

This CL makes PerformanceTests/DOM/select-single-remove.html faster.
On my local machine, 5.1 runs/s -> 45.1 runs/s

BUG=620142
==========

[tkent, 2016-06-20 08:48:15]

Description was changed from

==========
Improve performance to remove OPTIONs from a single-selection SELECT.

LayoutMenuList::updateOptionsHeightWidth() is a O(n) function to get maximum
OPTION width and height.

We had a bad performance because it is called whenever we remove a selected
OPTION from a SELECT. This CL changes the timing of updateOptionsHeightWidth().

Old:
  It was called by updateFromElement() after an OPTION is
  added/removed. updateOptionsHeightWidth() makes layout dirty only if maximum
  width/height was changed.

New:
  OPTION addition/removal makes maximum width/height dirty and makes layout
  dirty, and updateOptionsHeightWidth() is called only if the maximum
  width/height is referred.

The new behavior makes layout dirty more frequently, however it reduces the
number of updateOptionsHeightWidth() calls significantly.

This CL makes PerformanceTests/DOM/select-single-remove.html faster.
On my local machine, 5.1 runs/s -> 45.1 runs/s

BUG=620142
==========

to

==========
Improve performance to remove OPTIONs from a single-selection SELECT.

LayoutMenuList::updateOptionsHeightWidth() is an O(n) function to get maximum
OPTION width and height.

We had a bad performance because it is called whenever we remove a selected
OPTION from a SELECT. This CL changes the timing of updateOptionsHeightWidth().

Old:
  It was called by updateFromElement() after an OPTION is
  added/removed. updateOptionsHeightWidth() makes layout dirty only if maximum
  width/height was changed.

New:
  OPTION addition/removal makes maximum width/height dirty and makes layout
  dirty, and updateOptionsHeightWidth() is called only if the maximum
  width/height is referred.

The new behavior makes layout dirty more frequently, however it reduces the
number of updateOptionsHeightWidth() calls significantly.

This CL makes PerformanceTests/DOM/select-single-remove.html faster.
On my local machine, 5.1 runs/s -> 45.1 runs/s

BUG=620142
==========

[tkent, 2016-06-21 00:25:43]

Patchset #1 (id:20001) has been deleted

[tkent, 2016-06-21 02:26:20]

Patchset #1 (id:40001) has been deleted

[tkent, 2016-06-21 03:30:05]

Description was changed from

==========
Improve performance to remove OPTIONs from a single-selection SELECT.

LayoutMenuList::updateOptionsHeightWidth() is an O(n) function to get maximum
OPTION width and height.

We had a bad performance because it is called whenever we remove a selected
OPTION from a SELECT. This CL changes the timing of updateOptionsHeightWidth().

Old:
  It was called by updateFromElement() after an OPTION is
  added/removed. updateOptionsHeightWidth() makes layout dirty only if maximum
  width/height was changed.

New:
  OPTION addition/removal makes maximum width/height dirty and makes layout
  dirty, and updateOptionsHeightWidth() is called only if the maximum
  width/height is referred.

The new behavior makes layout dirty more frequently, however it reduces the
number of updateOptionsHeightWidth() calls significantly.

This CL makes PerformanceTests/DOM/select-single-remove.html faster.
On my local machine, 5.1 runs/s -> 45.1 runs/s

BUG=620142
==========

to

==========
Improve performance to remove OPTIONs from a single-selection SELECT.

LayoutMenuList::updateOptionsHeightWidth() is an O(n) function to get maximum
OPTION width and height.

We had a bad performance because it is called whenever we remove a selected
OPTION from a SELECT. This CL changes the timing of updateOptionsHeightWidth().

Old:
  It was called by updateFromElement() after an OPTION is
  added/removed. updateOptionsHeightWidth() makes layout dirty only if maximum
  width/height was changed.

New:
  OPTION addition/removal makes maximum width/height dirty and makes layout
  dirty, and updateOptionsHeightWidth() is called only if the maximum
  width/height is referred.

The new behavior makes layout dirty more frequently, however it reduces the
number of updateOptionsHeightWidth() calls significantly.

This CL makes PerformanceTests/DOM/select-single-remove.html faster.
On my local machine, 5.1 runs/s -> 45.1 runs/s

Test update:
* http/tests/webfont/popup-menu-load-webfont-after-open.html
  LayoutMenuList correctly updates its width and height after this CL.
* fast/repaint/control-clip.html
  Extra invalidation as expected.

BUG=620142
==========

[tkent, 2016-06-21 03:30:20]

tkent@chromium.org changed reviewers:
+ keishi@chromium.org

[tkent, 2016-06-21 03:30:21]

Keishi, would you review this please?

[keishi, 2016-06-21 05:10:37]

LGTM

[tkent, 2016-06-21 05:45:19]

The CQ bit was checked by tkent@chromium.org

[commit-bot: I haz the power, 2016-06-21 05:45:38]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2077343002/60001

[commit-bot: I haz the power, 2016-06-21 05:50:29]

Committed patchset #1 (id:60001)

[commit-bot: I haz the power, 2016-06-21 05:51:57]

Description was changed from

==========
Improve performance to remove OPTIONs from a single-selection SELECT.

LayoutMenuList::updateOptionsHeightWidth() is an O(n) function to get maximum
OPTION width and height.

We had a bad performance because it is called whenever we remove a selected
OPTION from a SELECT. This CL changes the timing of updateOptionsHeightWidth().

Old:
  It was called by updateFromElement() after an OPTION is
  added/removed. updateOptionsHeightWidth() makes layout dirty only if maximum
  width/height was changed.

New:
  OPTION addition/removal makes maximum width/height dirty and makes layout
  dirty, and updateOptionsHeightWidth() is called only if the maximum
  width/height is referred.

The new behavior makes layout dirty more frequently, however it reduces the
number of updateOptionsHeightWidth() calls significantly.

This CL makes PerformanceTests/DOM/select-single-remove.html faster.
On my local machine, 5.1 runs/s -> 45.1 runs/s

Test update:
* http/tests/webfont/popup-menu-load-webfont-after-open.html
  LayoutMenuList correctly updates its width and height after this CL.
* fast/repaint/control-clip.html
  Extra invalidation as expected.

BUG=620142
==========

to

==========
Improve performance to remove OPTIONs from a single-selection SELECT.

LayoutMenuList::updateOptionsHeightWidth() is an O(n) function to get maximum
OPTION width and height.

We had a bad performance because it is called whenever we remove a selected
OPTION from a SELECT. This CL changes the timing of updateOptionsHeightWidth().

Old:
  It was called by updateFromElement() after an OPTION is
  added/removed. updateOptionsHeightWidth() makes layout dirty only if maximum
  width/height was changed.

New:
  OPTION addition/removal makes maximum width/height dirty and makes layout
  dirty, and updateOptionsHeightWidth() is called only if the maximum
  width/height is referred.

The new behavior makes layout dirty more frequently, however it reduces the
number of updateOptionsHeightWidth() calls significantly.

This CL makes PerformanceTests/DOM/select-single-remove.html faster.
On my local machine, 5.1 runs/s -> 45.1 runs/s

Test update:
* http/tests/webfont/popup-menu-load-webfont-after-open.html
  LayoutMenuList correctly updates its width and height after this CL.
* fast/repaint/control-clip.html
  Extra invalidation as expected.

BUG=620142

Committed: https://crrev.com/1b32ab54ae3451e24152fc1e433b7e1cb44ac56e
Cr-Commit-Position: refs/heads/master@{#400903}
==========

[commit-bot: I haz the power, 2016-06-21 05:51:58]

Patchset 1 (id:??) landed as
https://crrev.com/1b32ab54ae3451e24152fc1e433b7e1cb44ac56e
Cr-Commit-Position: refs/heads/master@{#400903}