Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(447)

Unified Diff: third_party/WebKit/Source/core/layout/LayoutMenuList.h

Issue 2077343002: Improve performance to remove OPTIONs from a single-selection SELECT. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/layout/LayoutMenuList.h
diff --git a/third_party/WebKit/Source/core/layout/LayoutMenuList.h b/third_party/WebKit/Source/core/layout/LayoutMenuList.h
index f31cccedcfb71560be0be32eacbd59a67656aed7..70688355430ce255c90d4f14f17b0c8f67b097f0 100644
--- a/third_party/WebKit/Source/core/layout/LayoutMenuList.h
+++ b/third_party/WebKit/Source/core/layout/LayoutMenuList.h
@@ -39,7 +39,7 @@ public:
~LayoutMenuList() override;
HTMLSelectElement* selectElement() const;
- void setOptionsChanged(bool changed) { m_optionsChanged = changed; }
+ void setOptionsChanged(bool);
void didSetSelectedIndex(int optionIndex);
String text() const;
@@ -81,10 +81,9 @@ private:
void adjustInnerStyle();
void setText(const String&);
void setTextFromOption(int optionIndex);
- void updateOptionsHeightWidth();
+ void updateOptionsHeightWidth() const;
float computeTextHeight(const TextRun&, const ComputedStyle&) const;
float computeTextWidth(const TextRun&, const ComputedStyle&) const;
- void updateText();
void setIndexToSelectOnCancel(int listIndex);
void didUpdateActiveOption(int optionIndex);
@@ -92,11 +91,13 @@ private:
LayoutText* m_buttonText;
LayoutBlock* m_innerBlock;
- bool m_optionsChanged : 1;
+ mutable bool m_optionsChanged : 1;
bool m_isEmpty : 1;
bool m_hasUpdatedActiveOption : 1;
- int m_optionsHeight;
- int m_optionsWidth;
+ // m_optionsHeight and m_optionsWidth are calculated and cached on demand.
+ // updateOptionsHeightWidth() should be called before reading them.
+ mutable int m_optionsHeight;
+ mutable int m_optionsWidth;
int m_lastActiveIndex;

Powered by Google App Engine
This is Rietveld 408576698