Remove dependency on base/win/win_util.cc from crashpad.

Remove dependency on base/win/win_util.cc from crashpad.

Fixing the official ASAN builder which fails when
chrome_crash_reporter_client_win.cc is compiled with chrome_elf.dll

Crashpad is now included as part of chrome_elf and hence it cannot depend on functionality in base or elsewhere which pulls in user32

The ElfImportsTest.ChromeElfSanityCheck is disabled for
component builds to fix Dr Memory issues.

This reverts commit f546a78ac6eb865d418defe38cf70c1f0e3988c0.

BUG=621460
TBR=robertshield

Committed: https://crrev.com/e10c4579e9e096bd9af5174315c36ffcb9ab7af3
Cr-Commit-Position: refs/heads/master@{#400839}

[ananta, 2016-06-20 19:42:28]

ananta@chromium.org changed reviewers:
+ robertshield@chromium.org, scottmg@chromium.org

[ananta, 2016-06-20 19:46:01]

Description was changed from

==========
Remove dependency on base/win/win_util.cc from crashpad.

Fixing the official ASAN builder which fails when
chrome_crash_reporter_client_win.cc is compiled with chrome_elf.dll

This reverts commit f546a78ac6eb865d418defe38cf70c1f0e3988c0.

BUG=621460
==========

to

==========
Remove dependency on base/win/win_util.cc from crashpad.

Fixing the official ASAN builder which fails when
chrome_crash_reporter_client_win.cc is compiled with chrome_elf.dll

Crashpad is now included as part of chrome_elf and hence it cannot depend on
functionality in base or elsewhere which pulls in user32

This reverts commit f546a78ac6eb865d418defe38cf70c1f0e3988c0.

BUG=621460
==========

[scottmg, 2016-06-20 19:46:16]

scottmg@chromium.org changed reviewers:
+ chrisha@chromium.org

[scottmg, 2016-06-20 19:46:16]

EnumProcessModules is in kernel32 on 7. The copy of the function avoids some
win_util.cc deps as I understand it. So lgtm. +chrisha

[scottmg, 2016-06-20 19:47:53]

https://codereview.chromium.org/2077323004/diff/20001/chrome_elf/chrome_elf.gyp
File chrome_elf/chrome_elf.gyp (right):

https://codereview.chromium.org/2077323004/diff/20001/chrome_elf/chrome_elf.g...
chrome_elf/chrome_elf.gyp:40:
'../chrome/app/chrome_crash_reporter_client_win.cc',
Add the .h's here too.

https://codereview.chromium.org/2077323004/diff/20001/chrome_elf/elf_imports_...
File chrome_elf/elf_imports_unittest.cc (right):

https://codereview.chromium.org/2077323004/diff/20001/chrome_elf/elf_imports_...
chrome_elf/elf_imports_unittest.cc:65: #if defined(NDEBUG) &&
!defined(COMPONENT_BUILD)
Mention that this is for DrMemory in the CL description.

[ananta, 2016-06-20 19:50:30]

Description was changed from

==========
Remove dependency on base/win/win_util.cc from crashpad.

Fixing the official ASAN builder which fails when
chrome_crash_reporter_client_win.cc is compiled with chrome_elf.dll

Crashpad is now included as part of chrome_elf and hence it cannot depend on
functionality in base or elsewhere which pulls in user32

This reverts commit f546a78ac6eb865d418defe38cf70c1f0e3988c0.

BUG=621460
==========

to

==========
Remove dependency on base/win/win_util.cc from crashpad.

Fixing the official ASAN builder which fails when
chrome_crash_reporter_client_win.cc is compiled with chrome_elf.dll

Crashpad is now included as part of chrome_elf and hence it cannot depend on
functionality in base or elsewhere which pulls in user32

The ElfImportsTest.ChromeElfSanityCheck is disabled for
component builds to fix Dr Memory issues.

This reverts commit f546a78ac6eb865d418defe38cf70c1f0e3988c0.

BUG=621460
==========

[ananta, 2016-06-20 19:50:50]

https://codereview.chromium.org/2077323004/diff/20001/chrome_elf/chrome_elf.gyp
File chrome_elf/chrome_elf.gyp (right):

https://codereview.chromium.org/2077323004/diff/20001/chrome_elf/chrome_elf.g...
chrome_elf/chrome_elf.gyp:40:
'../chrome/app/chrome_crash_reporter_client_win.cc',
On 2016/06/20 19:47:52, scottmg (slow 20june) wrote:
> Add the .h's here too.

Done.

https://codereview.chromium.org/2077323004/diff/20001/chrome_elf/elf_imports_...
File chrome_elf/elf_imports_unittest.cc (right):

https://codereview.chromium.org/2077323004/diff/20001/chrome_elf/elf_imports_...
chrome_elf/elf_imports_unittest.cc:65: #if defined(NDEBUG) &&
!defined(COMPONENT_BUILD)
On 2016/06/20 19:47:53, scottmg (slow 20june) wrote:
> Mention that this is for DrMemory in the CL description.

Done.

[ananta, 2016-06-20 23:38:40]

Description was changed from

==========
Remove dependency on base/win/win_util.cc from crashpad.

Fixing the official ASAN builder which fails when
chrome_crash_reporter_client_win.cc is compiled with chrome_elf.dll

Crashpad is now included as part of chrome_elf and hence it cannot depend on
functionality in base or elsewhere which pulls in user32

The ElfImportsTest.ChromeElfSanityCheck is disabled for
component builds to fix Dr Memory issues.

This reverts commit f546a78ac6eb865d418defe38cf70c1f0e3988c0.

BUG=621460
==========

to

==========
Remove dependency on base/win/win_util.cc from crashpad.

Fixing the official ASAN builder which fails when
chrome_crash_reporter_client_win.cc is compiled with chrome_elf.dll

Crashpad is now included as part of chrome_elf and hence it cannot depend on
functionality in base or elsewhere which pulls in user32

The ElfImportsTest.ChromeElfSanityCheck is disabled for
component builds to fix Dr Memory issues.

This reverts commit f546a78ac6eb865d418defe38cf70c1f0e3988c0.

BUG=621460
TBR=robertshield
==========

[ananta, 2016-06-20 23:39:23]

TBR'ing robertshield as the change to chrome_elf is based on the previously
lgtm'ed patch. Will address comments in a followup.

[ananta, 2016-06-20 23:40:01]

The CQ bit was checked by ananta@chromium.org

[ananta, 2016-06-20 23:40:01]

The patchset sent to the CQ was uploaded after l-g-t-m from scottmg@chromium.org
Link to the patchset: https://codereview.chromium.org/2077323004/#ps40001
(title: "Address review comments and update patch description")

[commit-bot: I haz the power, 2016-06-20 23:40:21]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2077323004/40001

[commit-bot: I haz the power, 2016-06-20 23:50:05]

Description was changed from

==========
Remove dependency on base/win/win_util.cc from crashpad.

Fixing the official ASAN builder which fails when
chrome_crash_reporter_client_win.cc is compiled with chrome_elf.dll

Crashpad is now included as part of chrome_elf and hence it cannot depend on
functionality in base or elsewhere which pulls in user32

The ElfImportsTest.ChromeElfSanityCheck is disabled for
component builds to fix Dr Memory issues.

This reverts commit f546a78ac6eb865d418defe38cf70c1f0e3988c0.

BUG=621460
TBR=robertshield
==========

to

==========
Remove dependency on base/win/win_util.cc from crashpad.

Fixing the official ASAN builder which fails when
chrome_crash_reporter_client_win.cc is compiled with chrome_elf.dll

Crashpad is now included as part of chrome_elf and hence it cannot depend on
functionality in base or elsewhere which pulls in user32

The ElfImportsTest.ChromeElfSanityCheck is disabled for
component builds to fix Dr Memory issues.

This reverts commit f546a78ac6eb865d418defe38cf70c1f0e3988c0.

BUG=621460
TBR=robertshield
==========

[commit-bot: I haz the power, 2016-06-20 23:50:07]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-06-20 23:51:14]

Description was changed from

==========
Remove dependency on base/win/win_util.cc from crashpad.

Fixing the official ASAN builder which fails when
chrome_crash_reporter_client_win.cc is compiled with chrome_elf.dll

Crashpad is now included as part of chrome_elf and hence it cannot depend on
functionality in base or elsewhere which pulls in user32

The ElfImportsTest.ChromeElfSanityCheck is disabled for
component builds to fix Dr Memory issues.

This reverts commit f546a78ac6eb865d418defe38cf70c1f0e3988c0.

BUG=621460
TBR=robertshield
==========

to

==========
Remove dependency on base/win/win_util.cc from crashpad.

Fixing the official ASAN builder which fails when
chrome_crash_reporter_client_win.cc is compiled with chrome_elf.dll

Crashpad is now included as part of chrome_elf and hence it cannot depend on
functionality in base or elsewhere which pulls in user32

The ElfImportsTest.ChromeElfSanityCheck is disabled for
component builds to fix Dr Memory issues.

This reverts commit f546a78ac6eb865d418defe38cf70c1f0e3988c0.

BUG=621460
TBR=robertshield

Committed: https://crrev.com/e10c4579e9e096bd9af5174315c36ffcb9ab7af3
Cr-Commit-Position: refs/heads/master@{#400839}
==========

[commit-bot: I haz the power, 2016-06-20 23:51:15]

Patchset 3 (id:??) landed as
https://crrev.com/e10c4579e9e096bd9af5174315c36ffcb9ab7af3
Cr-Commit-Position: refs/heads/master@{#400839}

[robertshield, 2016-06-21 02:07:49]

Sorry for the delay, LGTM