Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(529)

Side by Side Diff: chrome_elf/BUILD.gn

Issue 2077323004: Remove dependency on base/win/win_util.cc from crashpad. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address review comments and update patch description Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | chrome_elf/DEPS » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2015 The Chromium Authors. All rights reserved. 1 # Copyright 2015 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import("//build/config/win/manifest.gni") 5 import("//build/config/win/manifest.gni")
6 import("//chrome/version.gni") 6 import("//chrome/version.gni")
7 import("//testing/test.gni") 7 import("//testing/test.gni")
8 8
9 process_version("chrome_elf_resources") { 9 process_version("chrome_elf_resources") {
10 template_file = chrome_version_rc_template 10 template_file = chrome_version_rc_template
11 sources = [ 11 sources = [
12 "chrome_elf.ver", 12 "chrome_elf.ver",
13 ] 13 ]
14 output = "$target_gen_dir/chrome_elf_version.rc" 14 output = "$target_gen_dir/chrome_elf_version.rc"
15 } 15 }
16 16
17 # This manifest matches what GYP produces. It may not even be necessary. 17 # This manifest matches what GYP produces. It may not even be necessary.
18 windows_manifest("chrome_elf_manifest") { 18 windows_manifest("chrome_elf_manifest") {
19 sources = [ 19 sources = [
20 as_invoker_manifest, 20 as_invoker_manifest,
21 ] 21 ]
22 type = "dll" 22 type = "dll"
23 } 23 }
24 24
25 # We should move chrome_result_codes.h to another target which does not bring 25 # We should move chrome_result_codes.h to another target which does not bring
26 # in the world. 26 # in the world.
27 shared_library("chrome_elf") { 27 shared_library("chrome_elf") {
28 sources = [ 28 sources = [
29 "//chrome/app/chrome_crash_reporter_client_win.cc",
30 "//chrome/app/chrome_crash_reporter_client_win.h",
31 "//chrome/common/chrome_result_codes.h",
29 "chrome_elf.def", 32 "chrome_elf.def",
30 "chrome_elf_main.cc", 33 "chrome_elf_main.cc",
31 "chrome_elf_main.h", 34 "chrome_elf_main.h",
32 ] 35 ]
33 deps = [ 36 deps = [
34 ":blacklist", 37 ":blacklist",
35 ":breakpad", 38 ":breakpad",
36 ":chrome_elf_manifest", 39 ":chrome_elf_manifest",
37 ":chrome_elf_resources", 40 ":chrome_elf_resources",
38 ":common", 41 ":common",
42 "//base",
39 "//build/config/sanitizers:deps", 43 "//build/config/sanitizers:deps",
40 "//chrome/install_static:install_static_util", 44 "//chrome/install_static:install_static_util",
45 "//components/crash/content/app",
46 "//components/crash/core/common",
47 "//content/public/common:result_codes",
41 ] 48 ]
42 configs += [ "//build/config/win:windowed" ] 49 configs += [ "//build/config/win:windowed" ]
43 configs -= [ "//build/config/win:console" ] 50 configs -= [ "//build/config/win:console" ]
44 ldflags = [ 51 ldflags = [
45 "/NODEFAULTLIB:user32.lib", 52 "/NODEFAULTLIB:user32.lib",
46 "/DELAYLOAD:dbghelp.dll", 53 "/DELAYLOAD:dbghelp.dll",
47 "/DELAYLOAD:ole32.dll", 54 "/DELAYLOAD:ole32.dll",
48 "/DELAYLOAD:psapi.dll", 55 "/DELAYLOAD:psapi.dll",
49 "/DELAYLOAD:rpcrt4.dll", 56 "/DELAYLOAD:rpcrt4.dll",
50 "/DELAYLOAD:shell32.dll", 57 "/DELAYLOAD:shell32.dll",
(...skipping 161 matching lines...) Expand 10 before | Expand all | Expand 10 after
212 # which does), Ninja would get confused and always rebuild this target because 219 # which does), Ninja would get confused and always rebuild this target because
213 # it sees a declared output file but that file doesn't exist on disk. 220 # it sees a declared output file but that file doesn't exist on disk.
214 loadable_module("blacklist_test_dll_3") { 221 loadable_module("blacklist_test_dll_3") {
215 sources = [ 222 sources = [
216 "blacklist/test/blacklist_test_dll_3.cc", 223 "blacklist/test/blacklist_test_dll_3.cc",
217 ] 224 ]
218 deps = [ 225 deps = [
219 "//build/config/sanitizers:deps", 226 "//build/config/sanitizers:deps",
220 ] 227 ]
221 } 228 }
OLDNEW
« no previous file with comments | « no previous file | chrome_elf/DEPS » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698