Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(653)

Issue 2077293002: Remove ellipsis from "Set wallpaper..." context menu item. (Closed)

Created:
4 years, 6 months ago by oka
Modified:
4 years, 6 months ago
Reviewers:
fukino
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove ellipsis from "Set wallpaper..." context menu item. BUG=620982 TEST=manually Committed: https://crrev.com/5a4ebed40bbadbe44df52ab3c7d73e8f22930524 Cr-Commit-Position: refs/heads/master@{#401203}

Patch Set 1 #

Patch Set 2 : Remove ... #

Patch Set 3 : Address comments #

Patch Set 4 : Nit #

Total comments: 2

Patch Set 5 : Address comments. #

Total comments: 1

Patch Set 6 : Address comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -1 line) Patch
M chrome/app/chromeos_strings.grdp View 1 2 3 4 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/extensions/file_manager/private_api_strings.cc View 1 2 3 4 5 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 18 (4 generated)
oka
PTAL
4 years, 6 months ago (2016-06-20 01:23:20 UTC) #2
fukino
As mentioned in the bug description, the same string is used in wallpaper manager, so ...
4 years, 6 months ago (2016-06-20 15:44:54 UTC) #3
oka
Address comments
4 years, 6 months ago (2016-06-21 03:35:42 UTC) #4
oka
Nit
4 years, 6 months ago (2016-06-21 03:41:06 UTC) #5
oka
PTAL
4 years, 6 months ago (2016-06-21 03:42:42 UTC) #6
fukino
https://codereview.chromium.org/2077293002/diff/60001/chrome/app/chromeos_strings.grdp File chrome/app/chromeos_strings.grdp (right): https://codereview.chromium.org/2077293002/diff/60001/chrome/app/chromeos_strings.grdp#newcode124 chrome/app/chromeos_strings.grdp:124: <message name="IDS_FILE_BROWSER_SET_WALLPAPER_MENU_ITEM" desc="The context menuitem to set wallpaper."> s/menuitem/menu ...
4 years, 6 months ago (2016-06-21 17:31:30 UTC) #7
oka
Address comments.
4 years, 6 months ago (2016-06-22 02:29:58 UTC) #8
oka
PTAL
4 years, 6 months ago (2016-06-22 02:31:47 UTC) #9
fukino
lgtm with a nit. https://codereview.chromium.org/2077293002/diff/80001/chrome/browser/chromeos/extensions/file_manager/private_api_strings.cc File chrome/browser/chromeos/extensions/file_manager/private_api_strings.cc (right): https://codereview.chromium.org/2077293002/diff/80001/chrome/browser/chromeos/extensions/file_manager/private_api_strings.cc#newcode565 chrome/browser/chromeos/extensions/file_manager/private_api_strings.cc:565: SET_STRING("FILE_BROWSER_SET_WALLPAPER_BUTTON_LABEL", nit: You don't need ...
4 years, 6 months ago (2016-06-22 02:47:13 UTC) #10
oka
Address comments.
4 years, 6 months ago (2016-06-22 03:23:59 UTC) #11
oka
4 years, 6 months ago (2016-06-22 03:29:42 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2077293002/100001
4 years, 6 months ago (2016-06-22 03:30:07 UTC) #15
commit-bot: I haz the power
Committed patchset #6 (id:100001)
4 years, 6 months ago (2016-06-22 04:07:19 UTC) #16
commit-bot: I haz the power
4 years, 6 months ago (2016-06-22 04:10:39 UTC) #18
Message was sent while issue was closed.
Patchset 6 (id:??) landed as
https://crrev.com/5a4ebed40bbadbe44df52ab3c7d73e8f22930524
Cr-Commit-Position: refs/heads/master@{#401203}

Powered by Google App Engine
This is Rietveld 408576698