Remove ellipsis from "Set wallpaper..." context menu item.

Remove ellipsis from "Set wallpaper..." context menu item.

BUG=620982
TEST=manually

Committed: https://crrev.com/5a4ebed40bbadbe44df52ab3c7d73e8f22930524
Cr-Commit-Position: refs/heads/master@{#401203}

[oka, 2016-06-20 01:23:19]

oka@chromium.org changed reviewers:
+ fukino@chromium.org

[oka, 2016-06-20 01:23:20]

PTAL

[fukino, 2016-06-20 15:44:54]

As mentioned in the bug description, the same string is used in wallpaper
manager, so we need new one.

[oka, 2016-06-21 03:35:42]

Address comments

[oka, 2016-06-21 03:41:06]

Nit

[oka, 2016-06-21 03:42:42]

PTAL

[fukino, 2016-06-21 17:31:30]

https://codereview.chromium.org/2077293002/diff/60001/chrome/app/chromeos_str...
File chrome/app/chromeos_strings.grdp (right):

https://codereview.chromium.org/2077293002/diff/60001/chrome/app/chromeos_str...
chrome/app/chromeos_strings.grdp:124: <message
name="IDS_FILE_BROWSER_SET_WALLPAPER_MENU_ITEM" desc="The context menuitem to
set wallpaper.">
s/menuitem/menu item

It's weird to insert this item between column labels.

https://codereview.chromium.org/2077293002/diff/60001/chrome/app/chromeos_str...
chrome/app/chromeos_strings.grdp:124: <message
name="IDS_FILE_BROWSER_SET_WALLPAPER_MENU_ITEM" desc="The context menuitem to
set wallpaper.">
You should check how other similar UI elements are defined/named.
For example, please try to be consistent with
IDS_FILE_BROWSER_ZIP_SELECTION_BUTTON_LABEL

[oka, 2016-06-22 02:29:58]

Address comments.

[oka, 2016-06-22 02:31:47]

PTAL

[fukino, 2016-06-22 02:47:13]

lgtm with a nit.

https://codereview.chromium.org/2077293002/diff/80001/chrome/browser/chromeos...
File chrome/browser/chromeos/extensions/file_manager/private_api_strings.cc
(right):

https://codereview.chromium.org/2077293002/diff/80001/chrome/browser/chromeos...
chrome/browser/chromeos/extensions/file_manager/private_api_strings.cc:565:
SET_STRING("FILE_BROWSER_SET_WALLPAPER_BUTTON_LABEL",
nit: You don't need to add prefix "FILE_BROWSER_" for this string.
"SET_WALLPAPER_BUTTON_LABEL" won't conflict with Wallpaper manager's one.

[oka, 2016-06-22 03:23:59]

Address comments.

[oka, 2016-06-22 03:29:52]

The CQ bit was checked by oka@chromium.org

[oka, 2016-06-22 03:29:52]

The patchset sent to the CQ was uploaded after l-g-t-m from fukino@chromium.org
Link to the patchset: https://codereview.chromium.org/2077293002/#ps100001
(title: "Address comments.")

[commit-bot: I haz the power, 2016-06-22 03:30:07]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2077293002/100001

[commit-bot: I haz the power, 2016-06-22 04:07:19]

Committed patchset #6 (id:100001)

[commit-bot: I haz the power, 2016-06-22 04:10:38]

Description was changed from

==========
Remove ellipsis from "Set wallpaper..." context menu item.

BUG=620982
TEST=manually
==========

to

==========
Remove ellipsis from "Set wallpaper..." context menu item.

BUG=620982
TEST=manually

Committed: https://crrev.com/5a4ebed40bbadbe44df52ab3c7d73e8f22930524
Cr-Commit-Position: refs/heads/master@{#401203}
==========

[commit-bot: I haz the power, 2016-06-22 04:10:39]

Patchset 6 (id:??) landed as
https://crrev.com/5a4ebed40bbadbe44df52ab3c7d73e8f22930524
Cr-Commit-Position: refs/heads/master@{#401203}