chrome/browser/chromeos/extensions/file_manager/private_api_strings.cc - Issue 2077293002: Remove ellipsis from "Set wallpaper..." context menu item.

Side by Side Diff: chrome/browser/chromeos/extensions/file_manager/private_api_strings.cc

Issue 2077293002: Remove ellipsis from "Set wallpaper..." context menu item. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address comments. Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « chrome/app/chromeos_strings.grdp ('k') | ui/file_manager/file_manager/main.html » ('j') | no next file with comments »

OLD	NEW
1 // Copyright 2013 The Chromium Authors. All rights reserved.	1 // Copyright 2013 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "chrome/browser/chromeos/extensions/file_manager/private_api_strings.h"	5 #include "chrome/browser/chromeos/extensions/file_manager/private_api_strings.h"

6	6

7 #include <memory>	7 #include <memory>

8 #include <utility>	8 #include <utility>

9	9

10 #include "base/strings/stringprintf.h"	10 #include "base/strings/stringprintf.h"

(...skipping 544 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
555 SET_STRING("TASKS_BUTTON_LABEL", IDS_FILE_BROWSER_TASKS_BUTTON_LABEL);	555 SET_STRING("TASKS_BUTTON_LABEL", IDS_FILE_BROWSER_TASKS_BUTTON_LABEL);

556 SET_STRING("TOGGLE_HIDDEN_FILES_COMMAND_LABEL",	556 SET_STRING("TOGGLE_HIDDEN_FILES_COMMAND_LABEL",

557 IDS_FILE_BROWSER_TOGGLE_HIDDEN_FILES_COMMAND_LABEL);	557 IDS_FILE_BROWSER_TOGGLE_HIDDEN_FILES_COMMAND_LABEL);

558 SET_STRING("SHARE_BUTTON_LABEL", IDS_FILE_BROWSER_SHARE_BUTTON_LABEL);	558 SET_STRING("SHARE_BUTTON_LABEL", IDS_FILE_BROWSER_SHARE_BUTTON_LABEL);

559 SET_STRING("CHANGE_TO_LISTVIEW_BUTTON_LABEL",	559 SET_STRING("CHANGE_TO_LISTVIEW_BUTTON_LABEL",

560 IDS_FILE_BROWSER_CHANGE_TO_LISTVIEW_BUTTON_LABEL);	560 IDS_FILE_BROWSER_CHANGE_TO_LISTVIEW_BUTTON_LABEL);

561 SET_STRING("CHANGE_TO_THUMBNAILVIEW_BUTTON_LABEL",	561 SET_STRING("CHANGE_TO_THUMBNAILVIEW_BUTTON_LABEL",

562 IDS_FILE_BROWSER_CHANGE_TO_THUMBNAILVIEW_BUTTON_LABEL);	562 IDS_FILE_BROWSER_CHANGE_TO_THUMBNAILVIEW_BUTTON_LABEL);

563 SET_STRING("CANCEL_SELECTION_BUTTON_LABEL",	563 SET_STRING("CANCEL_SELECTION_BUTTON_LABEL",

564 IDS_FILE_BROWSER_CANCEL_SELECTION_BUTTON_LABEL);	564 IDS_FILE_BROWSER_CANCEL_SELECTION_BUTTON_LABEL);

	565 SET_STRING("FILE_BROWSER_SET_WALLPAPER_BUTTON_LABEL",
	fukino 2016/06/22 02:47:13 nit: You don't need to add prefix "FILE_BROWSER_" nit: You don't need to add prefix "FILE_BROWSER_" for this string. "SET_WALLPAPER_BUTTON_LABEL" won't conflict with Wallpaper manager's one.
	566 IDS_FILE_BROWSER_SET_WALLPAPER_BUTTON_LABEL);

565 SET_STRING("SET_WALLPAPER_BUTTON_LABEL", IDS_SET_WALLPAPER_BUTTON);	567 SET_STRING("SET_WALLPAPER_BUTTON_LABEL", IDS_SET_WALLPAPER_BUTTON);

566 SET_STRING("SHARE_ERROR", IDS_FILE_BROWSER_SHARE_ERROR);	568 SET_STRING("SHARE_ERROR", IDS_FILE_BROWSER_SHARE_ERROR);

567	569

568 SET_STRING("SIZE_BYTES", IDS_FILE_BROWSER_SIZE_BYTES);	570 SET_STRING("SIZE_BYTES", IDS_FILE_BROWSER_SIZE_BYTES);

569 SET_STRING("SIZE_COLUMN_LABEL", IDS_FILE_BROWSER_SIZE_COLUMN_LABEL);	571 SET_STRING("SIZE_COLUMN_LABEL", IDS_FILE_BROWSER_SIZE_COLUMN_LABEL);

570 SET_STRING("SIZE_GB", IDS_FILE_BROWSER_SIZE_GB);	572 SET_STRING("SIZE_GB", IDS_FILE_BROWSER_SIZE_GB);

571 SET_STRING("SIZE_KB", IDS_FILE_BROWSER_SIZE_KB);	573 SET_STRING("SIZE_KB", IDS_FILE_BROWSER_SIZE_KB);

572 SET_STRING("SIZE_MB", IDS_FILE_BROWSER_SIZE_MB);	574 SET_STRING("SIZE_MB", IDS_FILE_BROWSER_SIZE_MB);

573 SET_STRING("SIZE_PB", IDS_FILE_BROWSER_SIZE_PB);	575 SET_STRING("SIZE_PB", IDS_FILE_BROWSER_SIZE_PB);

574 SET_STRING("SIZE_TB", IDS_FILE_BROWSER_SIZE_TB);	576 SET_STRING("SIZE_TB", IDS_FILE_BROWSER_SIZE_TB);

(...skipping 78 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
653 dict->SetString("UI_LOCALE", extension_l10n_util::CurrentLocaleOrDefault());	655 dict->SetString("UI_LOCALE", extension_l10n_util::CurrentLocaleOrDefault());

654	656

655 const std::string& app_locale = g_browser_process->GetApplicationLocale();	657 const std::string& app_locale = g_browser_process->GetApplicationLocale();

656 webui::SetLoadTimeDataDefaults(app_locale, dict.get());	658 webui::SetLoadTimeDataDefaults(app_locale, dict.get());

657 SetResult(std::move(dict));	659 SetResult(std::move(dict));

658	660

659 return true;	661 return true;

660 }	662 }

661	663

662 } // namespace extensions	664 } // namespace extensions

OLD	NEW