Rewrite scopes of non-simple default arguments

Rewrite scopes of non-simple default arguments

Default parameters have additional declaration block scopes inserted
around them when something in the function scope calls eval. This
patch sets the parent scope of the expressions introduced due to
those defaults to the new block scope.

R=adamk
BUG=chromium:616386
Committed: https://crrev.com/0e14baf712955a1993f742647bb2adc293702b80
Cr-Commit-Position: refs/heads/master@{#37198}

[Dan Ehrenberg, 2016-06-21 21:27:34]

The CQ bit was checked by littledan@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-06-21 21:27:43]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2077283004/40001

[Dan Ehrenberg, 2016-06-21 21:28:53]

The CQ bit was checked by littledan@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-06-21 21:29:04]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2077283004/60001

[commit-bot: I haz the power, 2016-06-21 21:32:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-21 21:32:24]

Dry run: Try jobs failed on following builders:
  v8_presubmit on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/17704)

[Dan Ehrenberg, 2016-06-21 23:12:55]

The CQ bit was checked by littledan@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-06-21 23:12:59]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2077283004/80001

[commit-bot: I haz the power, 2016-06-21 23:40:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-21 23:40:04]

Dry run: This issue passed the CQ dry run.

[adamk, 2016-06-22 17:55:39]

I'm happy to see the bug fixed, but wonder what the next step for making this
cleaner is, see question below.

https://codereview.chromium.org/2077283004/diff/80001/src/parsing/pattern-rew...
File src/parsing/pattern-rewriter.cc (right):

https://codereview.chromium.org/2077283004/diff/80001/src/parsing/pattern-rew...
src/parsing/pattern-rewriter.cc:693: // TODO(littledan): Remove the outer_scope
parameter of
How will removing this work? Is the idea to always use the passed-in scope's
outer_scope(), or search up those scopes? The tricky bit is that VariableProxies
don't know their scope.

[adamk, 2016-06-22 18:16:43]

lgtm to get this fixed expediently, and minimally (for back-porting purposes).

[Dan Ehrenberg, 2016-06-22 18:18:17]

The CQ bit was checked by littledan@chromium.org

[commit-bot: I haz the power, 2016-06-22 18:18:25]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2077283004/80001

[commit-bot: I haz the power, 2016-06-22 18:20:13]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-06-22 18:22:28]

Description was changed from

==========
Rewrite scopes of non-simple default arguments

Default parameters have additional declaration block scopes inserted
around them when something in the function scope calls eval. This
patch sets the parent scope of the expressions introduced due to
those defaults to the new block scope.

R=adamk
BUG=chromium:616386
==========

to

==========
Rewrite scopes of non-simple default arguments

Default parameters have additional declaration block scopes inserted
around them when something in the function scope calls eval. This
patch sets the parent scope of the expressions introduced due to
those defaults to the new block scope.

R=adamk
BUG=chromium:616386

Committed: https://crrev.com/0e14baf712955a1993f742647bb2adc293702b80
Cr-Commit-Position: refs/heads/master@{#37198}
==========

[commit-bot: I haz the power, 2016-06-22 18:22:29]

Patchset 5 (id:??) landed as
https://crrev.com/0e14baf712955a1993f742647bb2adc293702b80
Cr-Commit-Position: refs/heads/master@{#37198}

[Dan Ehrenberg, 2016-06-22 19:57:18]

A revert of this CL (patchset #5 id:80001) has been created in
https://codereview.chromium.org/2081323006/ by littledan@chromium.org.

The reason for reverting is: Seems to close tree (but it could be an infra
issue).