Windows GN build flag fixes.

Windows GN build flag fixes.

This brings some more flags in line with the GYP build on Windows. In particular, this ads the SSE2 flag on x86, and the stack linker flag on x64.

Committed: https://crrev.com/3665ae7d309c16b8685fcb6ab7aba141532f360d
Cr-Commit-Position: refs/heads/master@{#37114}

[brettw, 2016-06-17 23:43:13]

brettw@chromium.org changed reviewers:
+ jochen@chromium.org

[brettw, 2016-06-17 23:43:25]

The CQ bit was checked by brettw@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-06-17 23:43:29]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2077173002/1

[commit-bot: I haz the power, 2016-06-18 00:08:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-18 00:08:18]

Dry run: This issue passed the CQ dry run.

[jochen (gone - plz use gerrit), 2016-06-20 11:35:49]

lgtm

[jochen (gone - plz use gerrit), 2016-06-20 11:40:28]

jochen@chromium.org changed reviewers:
+ machenbach@chromium.org

[jochen (gone - plz use gerrit), 2016-06-20 11:40:29]

+machenbach fyi

[Michael Achenbach, 2016-06-20 11:59:21]

lgtm

https://codereview.chromium.org/2077173002/diff/1/BUILD.gn
File BUILD.gn (right):

https://codereview.chromium.org/2077173002/diff/1/BUILD.gn#newcode281
BUILD.gn:281: # Incrase the initial stack size. The default is 1MB, this is 2MB.
This
nit: Increase

https://codereview.chromium.org/2077173002/diff/1/BUILD.gn#newcode284
BUILD.gn:284: ldflags = [ "/STACK:2097152" ]
+= as it is defined above.

[brettw, 2016-06-20 17:37:08]

Review comments

[brettw, 2016-06-20 17:37:09]

The CQ bit was checked by brettw@chromium.org

[brettw, 2016-06-20 17:37:10]

The patchset sent to the CQ was uploaded after l-g-t-m from jochen@chromium.org,
machenbach@chromium.org
Link to the patchset: https://codereview.chromium.org/2077173002/#ps20001
(title: "Review comments")

[commit-bot: I haz the power, 2016-06-20 17:37:15]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2077173002/20001

[commit-bot: I haz the power, 2016-06-20 18:22:30]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-06-20 18:22:47]

Description was changed from

==========
Windows GN build flag fixes.

This brings some more flags in line with the GYP build on Windows. In
particular, this ads the SSE2 flag on x86, and the stack linker flag on x64.
==========

to

==========
Windows GN build flag fixes.

This brings some more flags in line with the GYP build on Windows. In
particular, this ads the SSE2 flag on x86, and the stack linker flag on x64.

Committed: https://crrev.com/3665ae7d309c16b8685fcb6ab7aba141532f360d
Cr-Commit-Position: refs/heads/master@{#37114}
==========

[commit-bot: I haz the power, 2016-06-20 18:22:48]

Patchset 2 (id:??) landed as
https://crrev.com/3665ae7d309c16b8685fcb6ab7aba141532f360d
Cr-Commit-Position: refs/heads/master@{#37114}