Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(494)

Side by Side Diff: BUILD.gn

Issue 2077173002: Windows GN build flag fixes. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Review comments Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import("//build/config/android/config.gni") 5 import("//build/config/android/config.gni")
6 import("//build/config/arm.gni") 6 import("//build/config/arm.gni")
7 import("//build/config/dcheck_always_on.gni") 7 import("//build/config/dcheck_always_on.gni")
8 import("//build/config/mips.gni") 8 import("//build/config/mips.gni")
9 import("//build/config/sanitizers/sanitizers.gni") 9 import("//build/config/sanitizers/sanitizers.gni")
10 10
(...skipping 146 matching lines...) Expand 10 before | Expand all | Expand 10 after
157 if (v8_use_external_startup_data) { 157 if (v8_use_external_startup_data) {
158 defines += [ "V8_USE_EXTERNAL_STARTUP_DATA" ] 158 defines += [ "V8_USE_EXTERNAL_STARTUP_DATA" ]
159 } 159 }
160 } 160 }
161 161
162 config("toolchain") { 162 config("toolchain") {
163 visibility = [ ":*" ] # Only targets in this file can depend on this. 163 visibility = [ ":*" ] # Only targets in this file can depend on this.
164 164
165 defines = [] 165 defines = []
166 cflags = [] 166 cflags = []
167 ldflags = []
167 168
168 if (v8_target_cpu == "arm") { 169 if (v8_target_cpu == "arm") {
169 defines += [ "V8_TARGET_ARCH_ARM" ] 170 defines += [ "V8_TARGET_ARCH_ARM" ]
170 if (arm_version == 7) { 171 if (arm_version == 7) {
171 defines += [ "CAN_USE_ARMV7_INSTRUCTIONS" ] 172 defines += [ "CAN_USE_ARMV7_INSTRUCTIONS" ]
172 } 173 }
173 if (arm_fpu == "vfpv3-d16") { 174 if (arm_fpu == "vfpv3-d16") {
174 defines += [ "CAN_USE_VFP3_INSTRUCTIONS" ] 175 defines += [ "CAN_USE_VFP3_INSTRUCTIONS" ]
175 } else if (arm_fpu == "vfpv3") { 176 } else if (arm_fpu == "vfpv3") {
176 defines += [ 177 defines += [
(...skipping 85 matching lines...) Expand 10 before | Expand all | Expand 10 after
262 defines += [ "V8_TARGET_ARCH_S390" ] 263 defines += [ "V8_TARGET_ARCH_S390" ]
263 if (v8_target_cpu == "s390x") { 264 if (v8_target_cpu == "s390x") {
264 defines += [ "V8_TARGET_ARCH_S390X" ] 265 defines += [ "V8_TARGET_ARCH_S390X" ]
265 } 266 }
266 if (host_cpu == "x64" || host_cpu == "x86") { 267 if (host_cpu == "x64" || host_cpu == "x86") {
267 defines += [ "V8_TARGET_ARCH_S390_LE_SIM" ] 268 defines += [ "V8_TARGET_ARCH_S390_LE_SIM" ]
268 } 269 }
269 } 270 }
270 if (v8_target_cpu == "x86") { 271 if (v8_target_cpu == "x86") {
271 defines += [ "V8_TARGET_ARCH_IA32" ] 272 defines += [ "V8_TARGET_ARCH_IA32" ]
273 if (is_win) {
274 # Ensure no surprising artifacts from 80bit double math with x86.
275 cflags += [ "/arch:SSE2" ]
276 }
272 } 277 }
273 if (v8_target_cpu == "x64") { 278 if (v8_target_cpu == "x64") {
274 defines += [ "V8_TARGET_ARCH_X64" ] 279 defines += [ "V8_TARGET_ARCH_X64" ]
280 if (is_win) {
281 # Increase the initial stack size. The default is 1MB, this is 2MB. This
282 # applies only to executables and shared libraries produced by V8 since
283 # ldflags are not pushed to dependants.
284 ldflags += [ "/STACK:2097152" ]
285 }
275 } 286 }
276 287
277 if (is_win) { 288 # TODO(jochen): Support v8_enable_prof on Windows.
278 defines += [ "WIN32" ]
279 # TODO(jochen): Support v8_enable_prof.
280 }
281
282 # TODO(jochen): Add support for compiling with simulators. 289 # TODO(jochen): Add support for compiling with simulators.
283 290
284 if (is_debug) { 291 if (is_debug) {
285 # TODO(jochen): Add support for different debug optimization levels. 292 # TODO(jochen): Add support for different debug optimization levels.
286 defines += [ 293 defines += [
287 "ENABLE_DISASSEMBLER", 294 "ENABLE_DISASSEMBLER",
288 "V8_ENABLE_CHECKS", 295 "V8_ENABLE_CHECKS",
289 "OBJECT_PRINT", 296 "OBJECT_PRINT",
290 "VERIFY_HEAP", 297 "VERIFY_HEAP",
291 "DEBUG", 298 "DEBUG",
(...skipping 1957 matching lines...) Expand 10 before | Expand all | Expand 10 after
2249 2256
2250 deps = [ 2257 deps = [
2251 ":fuzzer_support", 2258 ":fuzzer_support",
2252 ] 2259 ]
2253 2260
2254 configs = [ ":internal_config" ] 2261 configs = [ ":internal_config" ]
2255 } 2262 }
2256 2263
2257 v8_fuzzer("wasm_asmjs_fuzzer") { 2264 v8_fuzzer("wasm_asmjs_fuzzer") {
2258 } 2265 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698