Issue 20771002: Revert 213906 "base: Re-apply WeakPtr support for SequencedWorke..."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 20771002: Revert 213906 "base: Re-apply WeakPtr support for SequencedWorke..." (Closed)

Created:
7 years, 5 months ago by dewittj

Modified:
7 years, 5 months ago

Reviewers:
tommycli

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/

Visibility:
Public.

Revert 213906 "base: Re-apply WeakPtr support for SequencedWorke..." Speculative due to base_unittests failures. > base: Re-apply WeakPtr support for SequencedWorkerPools, fixing deadlock > > This reverts the revert found here: https://codereview.chromium.org/19882002 > > It also fixes the deadlock that caused the revert, reported here: > http://crbug.com/261448 > > Patchset 1 is simply what was originally committed (and reverted). Subsequent patchsets show the fix of the deadlock problem. > > BUG=165590 > TBR=darin > > Review URL: https://chromiumcodereview.appspot.com/20163004 TBR=tommycli@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=213943

Created: 7 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+73 lines, -377 lines)			Patch
M	trunk/src/base/base.gyp	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	trunk/src/base/memory/weak_ptr.h	View	2 chunks	+3 lines, -3 lines	0 comments	Download
M	trunk/src/base/memory/weak_ptr.cc	View	1 chunk	+6 lines, -6 lines	0 comments	Download
M	trunk/src/base/message_loop/message_pump_io_ios.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	trunk/src/base/sequence_checker.h	View	3 chunks	+14 lines, -2 lines	0 comments	Download
M	trunk/src/base/sequence_checker_impl.h	View	1 chunk	+24 lines, -18 lines	0 comments	Download
M	trunk/src/base/sequence_checker_impl.cc	View	1 chunk	+12 lines, -27 lines	0 comments	Download
A +	trunk/src/base/sequence_checker_impl_unittest.cc	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
M	trunk/src/base/sequence_checker_unittest.cc	View	1 chunk	+14 lines, -314 lines	0 comments	Download
M	trunk/src/base/threading/sequenced_worker_pool.cc	View	1 chunk	+0 lines, -4 lines	0 comments	Download
M	trunk/src/chrome/browser/storage_monitor/storage_monitor.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	trunk/src/content/renderer/media/webmediaplayer_ms.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	trunk/src/remoting/host/audio_capturer_win.h	View	1 chunk	+0 lines, -1 line	0 comments	Download

Total messages: 2 (0 generated)

Message was sent while issue was closed.

Committed patchset #1 manually as r213943.