Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Issue 19882002: Revert 211956 "base: Change WeakPtr to use SequenceChecker inste..." (Closed)

Created:
7 years, 5 months ago by vandebo (ex-Chrome)
Modified:
7 years, 5 months ago
Reviewers:
tommycli
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 211956 "base: Change WeakPtr to use SequenceChecker inste..." As well as revert 212725 "base: Make SequenceChecker death tests multi-threads work correctly." See http://crbug.com/261448 > base: Change WeakPtr to use SequenceChecker instead of ThreadChecker. > > This will enable WeakPtr to be used in SequencedWorkerPool, et al. with a sequence token. > > This is a continuation of issue: https://chromiumcodereview.appspot.com/18231002/ > > The original issue got messed up by a rietveld bug, so refer there for history and comments. > > BUG=165590 > > Review URL: https://chromiumcodereview.appspot.com/18501008 TBR=tommycli@chromium.org

Patch Set 1 #

Patch Set 2 : Fix patch and rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+296 lines, -384 lines) Patch
M base/base.gyp View 1 1 chunk +1 line, -0 lines 0 comments Download
M base/memory/weak_ptr.h View 1 2 chunks +3 lines, -3 lines 0 comments Download
M base/memory/weak_ptr.cc View 1 1 chunk +6 lines, -6 lines 0 comments Download
M base/message_loop/message_pump_io_ios.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M base/sequence_checker.h View 1 3 chunks +14 lines, -2 lines 0 comments Download
M base/sequence_checker_impl.h View 1 1 chunk +24 lines, -18 lines 0 comments Download
M base/sequence_checker_impl.cc View 1 1 chunk +12 lines, -27 lines 0 comments Download
A base/sequence_checker_impl_unittest.cc View 1 1 chunk +218 lines, -0 lines 0 comments Download
M base/sequence_checker_unittest.cc View 1 1 chunk +14 lines, -324 lines 0 comments Download
M chrome/browser/storage_monitor/storage_monitor.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M content/renderer/media/webmediaplayer_ms.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M remoting/host/audio_capturer_win.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M tools/valgrind/gtest_exclude/base_unittests.gtest.txt View 1 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
vandebo (ex-Chrome)
7 years, 5 months ago (2013-07-20 01:46:51 UTC) #1
vandebo (ex-Chrome)
7 years, 5 months ago (2013-07-20 06:14:40 UTC) #2
This CL seems to be borked.  Trying again in
https://codereview.chromium.org/19695005/

Powered by Google App Engine
This is Rietveld 408576698