[Autofill] Fix profiles with bad |use_date| values.

Fix profiles with bad |use_date| values.

A recent CL set the use date of new profiles to Now(). However, profiles that were created before and have not been used since still have the default value.

Adds a routine to set the use date of profiles for which it is set to the default value to two weeks before Now(). That routine will be run once per major version.

BUG=619587
TEST=PersonalDataManagerTest

Committed: https://crrev.com/e9ba60d7808bcdc37d8e6c69d036841a683b9e3e
Cr-Commit-Position: refs/heads/master@{#400526}

[Mathieu, 2016-06-17 17:23:54]

mathp@chromium.org changed reviewers:
+ sebsg@chromium.org

[Mathieu, 2016-06-17 17:24:22]

Hi Seb, PTAL

[sebsg, 2016-06-17 17:33:05]

LGTM % testing the pref (see comment).

Thanks!

https://codereview.chromium.org/2077003002/diff/1/components/autofill/core/br...
File components/autofill/core/browser/personal_data_manager_unittest.cc (right):

https://codereview.chromium.org/2077003002/diff/1/components/autofill/core/br...
components/autofill/core/browser/personal_data_manager_unittest.cc:4731:
saved_profiles[1]->use_date());
Could you also test that the fix is not applied a second time? Maybe re-set the
use_date to the default value, re-run and make sure the use_date didn't change?
Thanks!

[Mathieu, 2016-06-17 17:45:06]

The CQ bit was checked by mathp@chromium.org

[Mathieu, 2016-06-17 17:45:07]

The patchset sent to the CQ was uploaded after l-g-t-m from sebsg@chromium.org
Link to the patchset: https://codereview.chromium.org/2077003002/#ps20001
(title: "updated test")

[Mathieu, 2016-06-17 17:45:23]

https://codereview.chromium.org/2077003002/diff/1/components/autofill/core/br...
File components/autofill/core/browser/personal_data_manager_unittest.cc (right):

https://codereview.chromium.org/2077003002/diff/1/components/autofill/core/br...
components/autofill/core/browser/personal_data_manager_unittest.cc:4731:
saved_profiles[1]->use_date());
On 2016/06/17 at 17:33:05, sebsg wrote:
> Could you also test that the fix is not applied a second time? Maybe re-set
the use_date to the default value, re-run and make sure the use_date didn't
change? Thanks!

Done.

[commit-bot: I haz the power, 2016-06-17 17:45:32]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2077003002/20001

[commit-bot: I haz the power, 2016-06-17 18:41:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-17 18:41:37]

Try jobs failed on following builders:
  win_chromium_x64_rel_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[Mathieu, 2016-06-17 21:41:26]

The CQ bit was checked by mathp@chromium.org

[Mathieu, 2016-06-17 21:41:27]

The patchset sent to the CQ was uploaded after l-g-t-m from sebsg@chromium.org
Link to the patchset: https://codereview.chromium.org/2077003002/#ps80001
(title: "1line fix")

[commit-bot: I haz the power, 2016-06-17 21:42:14]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2077003002/80001

[commit-bot: I haz the power, 2016-06-17 22:27:01]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-06-17 22:29:03]

Description was changed from

==========
Fix profiles with bad |use_date| values.

A recent CL set the use date of new profiles to Now(). However, profiles that
were created before and have not been used since still have the default value.

Adds a routine to set the use date of profiles for which it is set to the
default value to two weeks before Now(). That routine will be run once per major
version.

BUG=619587
TEST=PersonalDataManagerTest
==========

to

==========
Fix profiles with bad |use_date| values.

A recent CL set the use date of new profiles to Now(). However, profiles that
were created before and have not been used since still have the default value.

Adds a routine to set the use date of profiles for which it is set to the
default value to two weeks before Now(). That routine will be run once per major
version.

BUG=619587
TEST=PersonalDataManagerTest

Committed: https://crrev.com/e9ba60d7808bcdc37d8e6c69d036841a683b9e3e
Cr-Commit-Position: refs/heads/master@{#400526}
==========

[commit-bot: I haz the power, 2016-06-17 22:29:05]

Patchset 5 (id:??) landed as
https://crrev.com/e9ba60d7808bcdc37d8e6c69d036841a683b9e3e
Cr-Commit-Position: refs/heads/master@{#400526}