[Autofill] Fix profiles with bad |use_date| values.

components/autofill/core/browser/personal_data_manager_unittest.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/autofill/core/browser/personal_data_manager.h"
 
 #include <stddef.h>
 
 #include <algorithm>
 #include <list>
@@ skipping 4650 matching lines @@
   // saved profiles plus 1 (imported profile count).
   EXPECT_EQ(profile1.use_count() + profile2.use_count() +
                 imported_profile.use_count(),
             profiles[0]->use_count());
   // The use date that results from the merge should be the one from the
   // imported profile since it was used just now.
   EXPECT_LT(base::Time::Now() - base::TimeDelta::FromSeconds(10),
             profiles[0]->use_date());
 }
 
+// Tests that ApplyProfileUseDatesFix sets the use date of profiles from an
+// incorrect value of 0 to [two weeks from now]. Also tests that SetProfiles
+// does not modify any other profiles.
+TEST_F(PersonalDataManagerTest, ApplyProfileUseDatesFix) {
+  // Set the kAutofillProfileUseDatesFixed pref to true so that the fix is not
+  // applied just yet.
+  personal_data_->pref_service_->SetBoolean(
+      prefs::kAutofillProfileUseDatesFixed, true);
+
+  // Create a profile. The use date will be set to now automatically.
+  AutofillProfile profile1(base::GenerateGUID(), "https://www.example.com");
+  test::SetProfileInfo(&profile1, "Homer", "Jay", "Simpson",
+                       "homer.simpson@abc.com", "SNP", "742 Evergreen Terrace",
+                       "", "Springfield", "IL", "91601", "US", "12345678910");
+
+  // Create another profile and set its use date to the default value.
+  AutofillProfile profile2(base::GenerateGUID(), "https://www.example.com");
+  test::SetProfileInfo(&profile2, "Marge", "", "Simpson",
+                       "homer.simpson@abc.com", "SNP", "742 Evergreen Terrace",
+                       "", "Springfield", "IL", "91601", "US", "12345678910");
+  profile2.set_use_date(base::Time());
+
+  personal_data_->AddProfile(profile1);
+  personal_data_->AddProfile(profile2);
+
+  EXPECT_CALL(personal_data_observer_, OnPersonalDataChanged())
+      .WillOnce(QuitMainMessageLoop());
+  base::MessageLoop::current()->Run();
+
+  // Get a sorted list of profiles. |profile1| will be first and |profile2| will
+  // be second.
+  std::vector<AutofillProfile*> saved_profiles =
+      personal_data_->GetProfilesToSuggest();
+
+  ASSERT_EQ(2U, saved_profiles.size());
+  // The use dates should not have been modified.
+  EXPECT_LE(base::Time::Now() - base::TimeDelta::FromDays(1),
+            saved_profiles[0]->use_date());
+  EXPECT_EQ(base::Time(), saved_profiles[1]->use_date());
+
+  // Set the pref to false to indicate the fix has never been run.
+  personal_data_->pref_service_->SetBoolean(
+      prefs::kAutofillProfileUseDatesFixed, false);
+  personal_data_->ApplyProfileUseDatesFix();
+
+  EXPECT_CALL(personal_data_observer_, OnPersonalDataChanged())
+      .WillOnce(QuitMainMessageLoop());
+  base::MessageLoop::current()->Run();
+
+  // Get a sorted list of profiles.
+  saved_profiles = personal_data_->GetProfilesToSuggest();
+
+  ASSERT_EQ(2U, saved_profiles.size());
+  // |profile1|'s use date should not have been modified.
+  EXPECT_LE(base::Time::Now() - base::TimeDelta::FromDays(1),
+            saved_profiles[0]->use_date());
+  // |profile2|'s use date should have been set to two weeks before now.
+  EXPECT_LE(base::Time::Now() - base::TimeDelta::FromDays(15),
+            saved_profiles[1]->use_date());
+  EXPECT_GE(base::Time::Now() - base::TimeDelta::FromDays(13),
+            saved_profiles[1]->use_date());

[sebsg, 2016/06/17 17:33:05]

Could you also test that the fix is not applied a second time? Maybe re-set the
use_date to the default value, re-run and make sure the use_date didn't change?
Thanks!

[Mathieu, 2016/06/17 17:45:23]

Done.

+}
+
 }  // namespace autofill