Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(320)

Issue 2076933002: Add more comprehensive tests for slotchange events (Closed)

Created:
4 years, 6 months ago by hayato
Modified:
4 years, 6 months ago
Reviewers:
tkent, kochi
CC:
blink-reviews, blink-reviews-html_chromium.org, chromium-reviews, dglazkov+blink
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add more comprehensive tests for slotchange events This CL also fixes an implementation bug of HTMLSlotElement::hasAssignedNodesSlow(), which a new test revealed. BUG=531990, 595287 Committed: https://crrev.com/20c30043cc1a130bb30e73242311c4b5a18783b3 Cr-Commit-Position: refs/heads/master@{#400632}

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+269 lines, -109 lines) Patch
A third_party/WebKit/LayoutTests/shadow-dom/slotchange.html View 1 chunk +268 lines, -0 lines 3 comments Download
D third_party/WebKit/LayoutTests/shadow-dom/slotchange-host-child-appended.html View 1 chunk +0 lines, -37 lines 0 comments Download
D third_party/WebKit/LayoutTests/shadow-dom/slotchange-node-removed.html View 1 chunk +0 lines, -34 lines 0 comments Download
D third_party/WebKit/LayoutTests/shadow-dom/slotchange-slotname-renamed.html View 1 chunk +0 lines, -37 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLSlotElement.cpp View 1 chunk +1 line, -1 line 0 comments Download

Dependent Patchsets:

Messages

Total messages: 25 (13 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2076933002/1
4 years, 6 months ago (2016-06-17 08:34:06 UTC) #2
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/240817)
4 years, 6 months ago (2016-06-17 11:33:55 UTC) #8
hayato
PTAL
4 years, 6 months ago (2016-06-17 12:18:28 UTC) #11
tkent
lgtm https://codereview.chromium.org/2076933002/diff/1/third_party/WebKit/LayoutTests/shadow-dom/slotchange.html File third_party/WebKit/LayoutTests/shadow-dom/slotchange.html (right): https://codereview.chromium.org/2076933002/diff/1/third_party/WebKit/LayoutTests/shadow-dom/slotchange.html#newcode19 third_party/WebKit/LayoutTests/shadow-dom/slotchange.html:19: slot.addEventListener('slotchange', test.step_func((e) => { nit: you can omit ...
4 years, 6 months ago (2016-06-20 01:52:31 UTC) #13
hayato
Thank you for the review. https://codereview.chromium.org/2076933002/diff/1/third_party/WebKit/LayoutTests/shadow-dom/slotchange.html File third_party/WebKit/LayoutTests/shadow-dom/slotchange.html (right): https://codereview.chromium.org/2076933002/diff/1/third_party/WebKit/LayoutTests/shadow-dom/slotchange.html#newcode19 third_party/WebKit/LayoutTests/shadow-dom/slotchange.html:19: slot.addEventListener('slotchange', test.step_func((e) => { ...
4 years, 6 months ago (2016-06-20 02:13:39 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2076933002/1
4 years, 6 months ago (2016-06-20 03:03:17 UTC) #16
tkent
https://codereview.chromium.org/2076933002/diff/1/third_party/WebKit/LayoutTests/shadow-dom/slotchange.html File third_party/WebKit/LayoutTests/shadow-dom/slotchange.html (right): https://codereview.chromium.org/2076933002/diff/1/third_party/WebKit/LayoutTests/shadow-dom/slotchange.html#newcode19 third_party/WebKit/LayoutTests/shadow-dom/slotchange.html:19: slot.addEventListener('slotchange', test.step_func((e) => { On 2016/06/20 at 02:13:39, hayato ...
4 years, 6 months ago (2016-06-20 03:03:58 UTC) #17
kochi
lgtm
4 years, 6 months ago (2016-06-20 04:40:13 UTC) #18
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/241468)
4 years, 6 months ago (2016-06-20 05:04:23 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2076933002/1
4 years, 6 months ago (2016-06-20 05:12:45 UTC) #22
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-20 07:27:53 UTC) #23
commit-bot: I haz the power
4 years, 6 months ago (2016-06-20 07:30:13 UTC) #25
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/20c30043cc1a130bb30e73242311c4b5a18783b3
Cr-Commit-Position: refs/heads/master@{#400632}

Powered by Google App Engine
This is Rietveld 408576698