third_party/WebKit/Source/core/html/HTMLSlotElement.cpp - Issue 2076933002: Add more comprehensive tests for slotchange events

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/HTMLSlotElement.cpp

Issue 2076933002: Add more comprehensive tests for slotchange events (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/html/HTMLSlotElement.cpp

diff --git a/third_party/WebKit/Source/core/html/HTMLSlotElement.cpp b/third_party/WebKit/Source/core/html/HTMLSlotElement.cpp

index 02e9279d0792cbb813b7d80195ed553274ce64ec..2af5bde13f26900e0d8b403d1a61251b83c4332c 100644

--- a/third_party/WebKit/Source/core/html/HTMLSlotElement.cpp

+++ b/third_party/WebKit/Source/core/html/HTMLSlotElement.cpp

@@ -315,7 +315,7 @@ bool HTMLSlotElement::hasAssignedNodesSlow() const

DCHECK(root);

DCHECK(root->isV1());

SlotAssignment& assignment = root->ensureSlotAssignment();

- if (assignment.findSlot(*this) != this)

+ if (assignment.findSlotByName(name()) != this)

return false;

return assignment.findHostChildBySlotName(name());

}