Change 'chromium_builder_tests' to be empty in GN builds.

Change 'chromium_builder_tests' to be empty in GN builds.

This was previous defined as a synonym for 'All', but using that
was causing things to be built unnecessarily on the builders, and
we're too close to the cycle time limit in the commit queue.

Really, we shouldn't ever be using this target anyway; builders should
either be building 'all' or a more specific list of targets rather
than some arbitrary grouping of stuff.

TBR=jam@chromium.org, brucedawson@chromium.org, brettw@chromium.org
BUG=617837
Committed: https://crrev.com/c7bbafa2ad385b444f5bd2125c95920c528e946e
Cr-Commit-Position: refs/heads/master@{#400335}

[Dirk Pranke, 2016-06-17 00:19:19]

The CQ bit was checked by dpranke@chromium.org to run a CQ dry run

[Dirk Pranke, 2016-06-17 00:19:39]

I fully expect this to break things, but it's theoretically the right fix for
the win CQ bots, so let's see what happens.

[commit-bot: I haz the power, 2016-06-17 00:20:15]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2076813002/1

[jam, 2016-06-17 00:20:31]

lgtm

[brucedawson, 2016-06-17 00:33:14]

lgtm

[commit-bot: I haz the power, 2016-06-17 00:35:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-17 00:35:42]

Dry run: Try jobs failed on following builders:
  chromeos_daisy_chromium_compile_only_ng on tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)
  chromeos_x86-generic_chromium_compile_only_ng on tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_x86-ge...)

[Dirk Pranke, 2016-06-17 02:37:45]

The CQ bit was checked by dpranke@chromium.org

[commit-bot: I haz the power, 2016-06-17 02:38:09]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2076813002/1

[commit-bot: I haz the power, 2016-06-17 03:02:17]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-06-17 03:03:37]

Description was changed from

==========
Change 'chromium_builder_tests' to be empty in GN builds.

This was previous defined as a synonym for 'All', but using that
was causing things to be built unnecessarily on the builders, and
we're too close to the cycle time limit in the commit queue.

Really, we shouldn't ever be using this target anyway; builders should
either be building 'all' or a more specific list of targets rather
than some arbitrary grouping of stuff.

TBR=jam@chromium.org, brucedawson@chromium.org, brettw@chromium.org
BUG=617837
==========

to

==========
Change 'chromium_builder_tests' to be empty in GN builds.

This was previous defined as a synonym for 'All', but using that
was causing things to be built unnecessarily on the builders, and
we're too close to the cycle time limit in the commit queue.

Really, we shouldn't ever be using this target anyway; builders should
either be building 'all' or a more specific list of targets rather
than some arbitrary grouping of stuff.

TBR=jam@chromium.org, brucedawson@chromium.org, brettw@chromium.org
BUG=617837

Committed: https://crrev.com/c7bbafa2ad385b444f5bd2125c95920c528e946e
Cr-Commit-Position: refs/heads/master@{#400335}
==========

[commit-bot: I haz the power, 2016-06-17 03:03:38]

Patchset 1 (id:??) landed as
https://crrev.com/c7bbafa2ad385b444f5bd2125c95920c528e946e
Cr-Commit-Position: refs/heads/master@{#400335}

[Nico, 2017-05-30 01:33:37]

thakis@chromium.org changed reviewers:
+ thakis@chromium.org

[Nico, 2017-05-30 01:33:38]

So it turns out that
https://build.chromium.org/p/chromium.win/builders/Win%20x64%20Builder%20(dbg)
still builds this target. This bot has been compiling nothing in the last 11.5
months – all the compile steps always say:

ninja: Entering directory `C:\b\c\b\Win_x64_Builder__dbg_\src\out\Debug_x64'
ninja: no work to do.

Among my questions are:

a) How did we fail to notice that a bot has been doing nothing for 11.5 months?
It's been green the whole day, but cycle time should've been suspiciously flat.

b) Do we still need that bot? Seems like it doesn't test a lot.

The Right Fix (tm) is probably to make that bot build a different target.

(I noticed this because I was watching the waterfall after the is_clang=true
switch on Windows and was surprised that this bot didn't build anything after a
compiler switch.)

[brucedawson, 2017-05-30 19:26:32]

On 2017/05/30 01:33:38, Nico wrote:
> So it turns out that
> https://build.chromium.org/p/chromium.win/builders/Win%20x64%20Builder%20(dbg)
> still builds this target. This bot has been compiling nothing in the last 11.5
> months – all the compile steps always say:
> 
> ninja: Entering directory `C:\b\c\b\Win_x64_Builder__dbg_\src\out\Debug_x64'
> ninja: no work to do.
> 
> Among my questions are:
> 
> a) How did we fail to notice that a bot has been doing nothing for 11.5
months?
> It's been green the whole day, but cycle time should've been suspiciously
flat.

Woah. Crazy. Building a different target sounds like a good plan - and deleting
the empty target as well, which would also have caught this presumably.

[Nico, 2017-05-30 20:35:21]

I filed https://bugs.chromium.org/p/chromium/issues/detail?id=727849 for this