Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(229)

Unified Diff: BUILD.gn

Issue 2076813002: Change 'chromium_builder_tests' to be empty in GN builds. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: BUILD.gn
diff --git a/BUILD.gn b/BUILD.gn
index 0a7fe5675d940c85d2fbaf89383c8019eed5e45c..84e1a54b64b9e2eee51a62685f796110a917424d 100644
--- a/BUILD.gn
+++ b/BUILD.gn
@@ -85,14 +85,14 @@ group("All") {
}
# TODO(GYP_GONE): This target exists for compatibility with GYP for the
-# builders. For now, this builds everything. We should decide if we want to
-# build less.
+# builders that specify targets in the recipes directly.
+# Ideally it should not exist, and the builders should be specifying
+# more specific targets (or 'All') via the source-side
+# //testing/buildbot/*.json files. We should simply delete this target
+# and update any recipes that are using it.
group("chromium_builder_tests") {
testonly = true
-
- deps = [
- ":All",
- ]
+ deps = []
}
if (is_chromeos) {
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698