Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2076613002: use py3 compatible octal constants (Closed)

Created:
4 years, 6 months ago by vapier
Modified:
4 years, 6 months ago
Reviewers:
nodir, Matt Giuca
CC:
chromium-reviews, dpranke+depot_tools_chromium.org, iannucci+depot_tools_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/depot_tools.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -8 lines) Patch
M testing_support/gerrit_test_case.py View 2 chunks +2 lines, -2 lines 0 comments Download
M testing_support/git_test_utils.py View 1 chunk +1 line, -1 line 0 comments Download
M tests/git_common_test.py View 2 chunks +2 lines, -2 lines 0 comments Download
M tests/git_hyper_blame_test.py View 1 chunk +1 line, -1 line 0 comments Download
M third_party/upload.py View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
vapier
4 years, 6 months ago (2016-06-16 17:57:30 UTC) #2
nodir
lgtm
4 years, 6 months ago (2016-06-16 18:23:21 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2076613002/1
4 years, 6 months ago (2016-06-16 18:36:57 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/tools/depot_tools/+/8057ac8802777b8bf1cd72f0790a23447a37f280
4 years, 6 months ago (2016-06-16 18:40:17 UTC) #7
Matt Giuca
Cool! But... "0o0" is unnecessary, you can just use "0o". Uploading a new CL to ...
4 years, 6 months ago (2016-06-17 04:13:05 UTC) #8
Matt Giuca
4 years, 6 months ago (2016-06-17 04:13:53 UTC) #9
Message was sent while issue was closed. 
On 2016/06/17 04:13:05, Matt Giuca wrote:
> Cool! But... "0o0" is unnecessary, you can just use "0o". Uploading a new CL
to
> fix this.

https://codereview.chromium.org/2075923003

Powered by Google App Engine
This is Rietveld 408576698