Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(550)

Issue 2075923003: Simplify octal constants in Python code (e.g. 0o0700 -> 0o700). (Closed)

Created:
4 years, 6 months ago by Matt Giuca
Modified:
4 years, 6 months ago
Reviewers:
vapier, nodir
CC:
chrome-apps-syd-reviews_chromium.org, chromium-reviews, dpranke+depot_tools_chromium.org, iannucci+depot_tools_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/depot_tools.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Simplify octal constants in Python code (e.g. 0o0700 -> 0o700). Committed: https://chromium.googlesource.com/chromium/tools/depot_tools/+/1dfe43ca1aec9d1e6f8982450dbc7bda6750d910

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -8 lines) Patch
M testing_support/gerrit_test_case.py View 2 chunks +2 lines, -2 lines 0 comments Download
M testing_support/git_test_utils.py View 1 chunk +1 line, -1 line 0 comments Download
M tests/git_common_test.py View 2 chunks +2 lines, -2 lines 0 comments Download
M tests/git_hyper_blame_test.py View 1 chunk +1 line, -1 line 0 comments Download
M third_party/upload.py View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 18 (7 generated)
Matt Giuca
Amendment to https://codereview.chromium.org/2076613002.
4 years, 6 months ago (2016-06-17 04:14:26 UTC) #2
vapier
lgtm
4 years, 6 months ago (2016-06-17 04:16:02 UTC) #3
nodir
On 2016/06/17 04:16:02, vapier wrote: > lgtm How about just 0?
4 years, 6 months ago (2016-06-17 04:56:35 UTC) #4
Matt Giuca
On 2016/06/17 04:56:35, nodir wrote: > On 2016/06/17 04:16:02, vapier wrote: > > lgtm > ...
4 years, 6 months ago (2016-06-17 04:57:42 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2075923003/1
4 years, 6 months ago (2016-06-17 04:58:35 UTC) #7
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
4 years, 6 months ago (2016-06-17 04:58:38 UTC) #9
Matt Giuca
Oops, didn't realise an OWNER was required. PTAL, nodir. thx
4 years, 6 months ago (2016-06-17 05:31:15 UTC) #11
nodir
ah, I just read the diff. lgtm before that I read only commit message and ...
4 years, 6 months ago (2016-06-17 05:58:27 UTC) #12
Matt Giuca
On 2016/06/17 05:58:27, nodir wrote: > before that I read only commit message and 0o0 ...
4 years, 6 months ago (2016-06-17 06:06:31 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2075923003/1
4 years, 6 months ago (2016-06-17 06:07:34 UTC) #16
commit-bot: I haz the power
4 years, 6 months ago (2016-06-17 06:10:49 UTC) #18
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/tools/depot_tools/+/1dfe43ca1aec9d...

Powered by Google App Engine
This is Rietveld 408576698