Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(95)

Issue 2076433002: Revert of Add support in Chrome to send notifications to a specific device. (Closed)

Created:
4 years, 6 months ago by rkc
Modified:
4 years, 6 months ago
Reviewers:
scheib, xiyuan
CC:
chromium-reviews, scheib+watch_chromium.org, ortuno+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Add support in Chrome to send notifications to a specific device. (patchset #3 id:40001 of https://codereview.chromium.org/2039773005/ ) Reason for revert: Original bug is not WontFix. Original issue's description: > Add support in Chrome to send notifications to a specific device. > > This CL adds the Chrome side support for sending notications to a specific > device as well as specifying whether an indiciation or notification should > be used. > > Reviews requested: > > xiyuan@ - general review > scheib@ - owner's review for the tests > > R=scheib@chromium.org, xiyuan@chromium.org > BUG=617745 > > Committed: https://crrev.com/29d3f15b5d1e6e99da160f46e29231c68e5f3938 > Cr-Commit-Position: refs/heads/master@{#399475} TBR=scheib@chromium.org,xiyuan@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=617745 Committed: https://crrev.com/7b06678e016f208aa77857a82325180ef3c75705 Cr-Commit-Position: refs/heads/master@{#400068}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -173 lines) Patch
M device/bluetooth/bluetooth_local_gatt_characteristic_unittest.cc View 3 chunks +14 lines, -59 lines 0 comments Download
M device/bluetooth/bluez/bluetooth_adapter_bluez.h View 1 chunk +3 lines, -6 lines 0 comments Download
M device/bluetooth/bluez/bluetooth_adapter_bluez.cc View 1 chunk +3 lines, -12 lines 0 comments Download
M device/bluetooth/bluez/bluetooth_local_gatt_characteristic_bluez.cc View 1 chunk +1 line, -2 lines 0 comments Download
M device/bluetooth/dbus/bluetooth_gatt_application_service_provider.h View 1 chunk +2 lines, -4 lines 0 comments Download
M device/bluetooth/dbus/bluetooth_gatt_application_service_provider.cc View 2 chunks +2 lines, -4 lines 0 comments Download
M device/bluetooth/dbus/bluetooth_gatt_application_service_provider_unittest.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M device/bluetooth/dbus/bluetooth_gatt_characteristic_service_provider.h View 1 chunk +1 line, -3 lines 0 comments Download
M device/bluetooth/dbus/bluetooth_gatt_characteristic_service_provider_impl.h View 1 chunk +1 line, -3 lines 0 comments Download
M device/bluetooth/dbus/bluetooth_gatt_characteristic_service_provider_impl.cc View 1 chunk +1 line, -3 lines 0 comments Download
M device/bluetooth/dbus/fake_bluetooth_gatt_characteristic_service_provider.h View 5 chunks +5 lines, -14 lines 0 comments Download
M device/bluetooth/dbus/fake_bluetooth_gatt_characteristic_service_provider.cc View 1 chunk +2 lines, -6 lines 0 comments Download
M device/bluetooth/test/bluetooth_test.h View 2 chunks +1 line, -14 lines 0 comments Download
M device/bluetooth/test/bluetooth_test.cc View 2 chunks +2 lines, -20 lines 0 comments Download
M device/bluetooth/test/bluetooth_test_bluez.h View 1 chunk +1 line, -1 line 0 comments Download
M device/bluetooth/test/bluetooth_test_bluez.cc View 3 chunks +3 lines, -19 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
rkc
Created Revert of Add support in Chrome to send notifications to a specific device.
4 years, 6 months ago (2016-06-16 00:04:36 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2076433002/1
4 years, 6 months ago (2016-06-16 00:05:11 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-16 01:18:59 UTC) #5
commit-bot: I haz the power
CQ bit was unchecked
4 years, 6 months ago (2016-06-16 01:19:16 UTC) #6
commit-bot: I haz the power
4 years, 6 months ago (2016-06-16 01:22:03 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7b06678e016f208aa77857a82325180ef3c75705
Cr-Commit-Position: refs/heads/master@{#400068}

Powered by Google App Engine
This is Rietveld 408576698