device/bluetooth/dbus/bluetooth_gatt_application_service_provider.cc - Issue 2076433002: Revert of Add support in Chrome to send notifications to a specific device.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: device/bluetooth/dbus/bluetooth_gatt_application_service_provider.cc

Issue 2076433002: Revert of Add support in Chrome to send notifications to a specific device. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « device/bluetooth/dbus/bluetooth_gatt_application_service_provider.h ('k') | device/bluetooth/dbus/bluetooth_gatt_application_service_provider_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: device/bluetooth/dbus/bluetooth_gatt_application_service_provider.cc

diff --git a/device/bluetooth/dbus/bluetooth_gatt_application_service_provider.cc b/device/bluetooth/dbus/bluetooth_gatt_application_service_provider.cc

index 730f730dd60d2854204b0642cf12a9e870f05e1b..c32c0ad7e6fe87a0e63dab68153b41858fa13024 100644

--- a/device/bluetooth/dbus/bluetooth_gatt_application_service_provider.cc

+++ b/device/bluetooth/dbus/bluetooth_gatt_application_service_provider.cc

@@ -136,10 +136,8 @@

}

void BluetoothGattApplicationServiceProvider::SendValueChanged(

- const dbus::ObjectPath& device_path,

const dbus::ObjectPath& characteristic_path,

- const std::vector<uint8_t>& value,

- bool indicate) {

+ const std::vector<uint8_t>& value) {

auto characteristic = std::find_if(

characteristic_providers_.begin(), characteristic_providers_.end(),

[&](const std::unique_ptr<BluetoothGattCharacteristicServiceProvider>&

@@ -149,7 +147,7 @@

<< characteristic_path.value();

return;

}

- characteristic->get()->SendValueChanged(device_path, value, indicate);

+ characteristic->get()->SendValueChanged(value);

}

// static