Create new Autofill tables as part of DB migration.

Create new Autofill tables as part of DB migration.

Currently, migration from a version 20 database to the latest version fails,
because the migration code assumes that the autofill_dates table exists, but it
was not present at version 20, and is never created during migration.  This CL
fixes the migration path to be more careful and more sane.

BUG=none
TEST=unit_tests
R=pkasting@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=259166

[Peter Kasting, 2014-03-21 18:20:12]

LGTM

https://codereview.chromium.org/207643002/diff/1/components/webdata/common/we...
File components/webdata/common/web_database.cc (right):

https://codereview.chromium.org/207643002/diff/1/components/webdata/common/we...
components/webdata/common/web_database.cc:115: // Create the desired SQL tables
if they do not already exist.
You might want to comment here and/or at the Init() loop above why
(a) These two loops are separate and
(b) This one has to come after the migration call

[Ilya Sherman, 2014-03-21 23:12:47]

+Jói for OWNERS review of everything outside of //components/webdata (though, of
course, feel free to take a look at that too).

https://codereview.chromium.org/207643002/diff/1/components/webdata/common/we...
File components/webdata/common/web_database.cc (right):

https://codereview.chromium.org/207643002/diff/1/components/webdata/common/we...
components/webdata/common/web_database.cc:115: // Create the desired SQL tables
if they do not already exist.
On 2014/03/21 18:20:13, Peter Kasting wrote:
> You might want to comment here and/or at the Init() loop above why
> (a) These two loops are separate and
> (b) This one has to come after the migration call

Done.

[Jói, 2014-03-24 19:33:44]

LGTM

[Ilya Sherman, 2014-03-24 19:38:38]

The CQ bit was checked by isherman@chromium.org

[commit-bot: I haz the power, 2014-03-24 19:39:08]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/isherman@chromium.org/207643002/40001

[commit-bot: I haz the power, 2014-03-24 19:46:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-03-24 19:46:06]

Try jobs failed on following builders:
  tryserver.chromium on win_chromium_compile_dbg

[Ilya Sherman, 2014-03-24 19:50:28]

The CQ bit was checked by isherman@chromium.org

[commit-bot: I haz the power, 2014-03-24 19:51:19]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/isherman@chromium.org/207643002/40001

[commit-bot: I haz the power, 2014-03-25 01:58:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-03-25 01:58:10]

Failed to apply patch for components/signin/core/webdata/token_service_table.cc:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  can't find file to patch at input line 6
  Perhaps you used the wrong -p or --strip option?
  The text leading up to this was:
  --------------------------
  |Index: components/signin/core/webdata/token_service_table.cc
  |diff --git a/components/signin/core/webdata/token_service_table.cc
b/components/signin/core/webdata/token_service_table.cc
  |index
7d51a02a80f08d2d19897ff4c00ded29aace99d5..bd7441f3df1edec153dcc38052e13845bf10fbd2
100644
  |--- a/components/signin/core/webdata/token_service_table.cc
  |+++ b/components/signin/core/webdata/token_service_table.cc
  --------------------------
  No file to patch.  Skipping patch.
  1 out of 1 hunk ignored

Patch:       components/signin/core/webdata/token_service_table.cc
Index: components/signin/core/webdata/token_service_table.cc
diff --git a/components/signin/core/webdata/token_service_table.cc
b/components/signin/core/webdata/token_service_table.cc
index
7d51a02a80f08d2d19897ff4c00ded29aace99d5..bd7441f3df1edec153dcc38052e13845bf10fbd2
100644
--- a/components/signin/core/webdata/token_service_table.cc
+++ b/components/signin/core/webdata/token_service_table.cc
@@ -32,8 +32,7 @@ WebDatabaseTable::TypeKey TokenServiceTable::GetTypeKey()
const {
   return GetKey();
 }
 
-bool TokenServiceTable::Init(sql::Connection* db, sql::MetaTable* meta_table) {
-  WebDatabaseTable::Init(db, meta_table);
+bool TokenServiceTable::CreateTablesIfNecessary() {
   if (!db_->DoesTableExist("token_service")) {
     if (!db_->Execute("CREATE TABLE token_service ("
                       "service VARCHAR PRIMARY KEY NOT NULL,"

[Ilya Sherman, 2014-03-25 04:41:09]

The CQ bit was checked by isherman@chromium.org

[commit-bot: I haz the power, 2014-03-25 04:41:31]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/isherman@chromium.org/207643002/50001

[commit-bot: I haz the power, 2014-03-25 06:38:49]

Change committed as 259166