Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(761)

Unified Diff: components/webdata/common/web_database_table.h

Issue 207643002: Create new Autofill tables as part of DB migration. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebase Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/webdata/common/web_database_table.h
diff --git a/components/webdata/common/web_database_table.h b/components/webdata/common/web_database_table.h
index b920ff61f163f4fdd02cc270ef66adbb0bd7b717..d931c870051eab0c535a095b4793ab0c24f84991 100644
--- a/components/webdata/common/web_database_table.h
+++ b/components/webdata/common/web_database_table.h
@@ -29,11 +29,12 @@ class WEBDATA_EXPORT WebDatabaseTable {
// Retrieves the TypeKey for the concrete subtype.
virtual TypeKey GetTypeKey() const = 0;
- // Attempts to initialize the table and returns true if successful.
- //
- // The base class stores the members passed and always return true;
- // subclasses may perform other initialization as needed.
- virtual bool Init(sql::Connection* db, sql::MetaTable* meta_table);
+ // Stores the passed members as instance variables.
+ void Init(sql::Connection* db, sql::MetaTable* meta_table);
+
+ // Create all of the expected SQL tables if they do not already exist.
+ // Returns true on success, false on failure.
+ virtual bool CreateTablesIfNecessary() = 0;
// In order to encourage developers to think about sync when adding or
// or altering new tables, this method must be implemented. Please get in
« no previous file with comments | « components/webdata/common/web_database_migration_unittest.cc ('k') | components/webdata/common/web_database_table.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698