Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Issue 2076263003: Plumb the handle signals state to Awakable::Awake(). (Closed)

Created:
4 years, 6 months ago by viettrungluu
Modified:
4 years, 6 months ago
Reviewers:
vardhan
CC:
mojo-reviews_chromium.org, gregsimon, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://github.com/domokit/mojo.git@work794_wait_set_4.2
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Plumb the handle signals state to Awakable::Awake(). Also switch from passing a MojoResult to a more specific reason. (This makes it explicit that there are only three possible reasons/results.) For persistent awakables (like wait sets), it's desirable to also observe state changes. R=vardhan@google.com BUG=#350 Committed: https://chromium.googlesource.com/external/mojo/+/6fd33f6a3d027e12c5bfcbd8c43fe01c15b76e92

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+133 lines, -62 lines) Patch
M mojo/edk/system/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M mojo/edk/system/async_waiter.h View 1 chunk +3 lines, -1 line 0 comments Download
M mojo/edk/system/async_waiter.cc View 1 chunk +4 lines, -2 lines 0 comments Download
M mojo/edk/system/awakable.h View 2 chunks +12 lines, -1 line 0 comments Download
A mojo/edk/system/awakable.cc View 1 chunk +27 lines, -0 lines 0 comments Download
M mojo/edk/system/awakable_list.cc View 3 chunks +11 lines, -8 lines 0 comments Download
M mojo/edk/system/awakable_list_unittest.cc View 2 chunks +6 lines, -2 lines 0 comments Download
M mojo/edk/system/core_unittest.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M mojo/edk/system/wait_set_dispatcher.h View 1 chunk +3 lines, -1 line 0 comments Download
M mojo/edk/system/wait_set_dispatcher.cc View 3 chunks +17 lines, -18 lines 0 comments Download
M mojo/edk/system/waiter.h View 1 chunk +4 lines, -3 lines 0 comments Download
M mojo/edk/system/waiter.cc View 1 chunk +4 lines, -2 lines 0 comments Download
M mojo/edk/system/waiter_unittest.cc View 12 chunks +38 lines, -22 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 4 (1 generated)
viettrungluu
4 years, 6 months ago (2016-06-17 22:50:20 UTC) #1
vardhan
Linux build fails (assuming it is flaky) lgtm otherwise
4 years, 6 months ago (2016-06-21 07:31:20 UTC) #2
viettrungluu
4 years, 6 months ago (2016-06-21 15:32:37 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
6fd33f6a3d027e12c5bfcbd8c43fe01c15b76e92 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698