Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(210)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2075353002: Plumb the handle signals state out of Waiter::Wait(). (Closed)

Created:
4 years, 6 months ago by viettrungluu
Modified:
4 years, 6 months ago
Reviewers:
vardhan
CC:
mojo-reviews_chromium.org, gregsimon, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://github.com/domokit/mojo.git@work795_wait_set_4.3-x-work794_wait_set_4.2
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Plumb the handle signals state out of Waiter::Wait(). Also make Waiter operate internally using AwakableReason instead of MojoResult. (The reason Wait() still returns a MojoResult is that AwakableReason doesn't have a "deadline exceeded".) R=vardhan@google.com BUG=#350 Committed: https://chromium.googlesource.com/external/mojo/+/ac1b628f7867016f33edb467ec0c525bf2254aa1

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+234 lines, -155 lines) Patch
M mojo/edk/system/channel_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/edk/system/core.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/edk/system/data_pipe_impl_unittest.cc View 44 chunks +58 lines, -44 lines 0 comments Download
M mojo/edk/system/ipc_support_unittest.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M mojo/edk/system/message_pipe_dispatcher_unittest.cc View 5 chunks +7 lines, -5 lines 0 comments Download
M mojo/edk/system/message_pipe_test_utils.cc View 1 chunk +2 lines, -1 line 0 comments Download
M mojo/edk/system/message_pipe_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M mojo/edk/system/remote_data_pipe_impl_unittest.cc View 8 chunks +15 lines, -8 lines 0 comments Download
M mojo/edk/system/remote_message_pipe_unittest.cc View 19 chunks +37 lines, -19 lines 0 comments Download
M mojo/edk/system/simple_dispatcher_unittest.cc View 11 chunks +14 lines, -11 lines 0 comments Download
M mojo/edk/system/waiter.h View 2 chunks +14 lines, -22 lines 0 comments Download
M mojo/edk/system/waiter.cc View 5 chunks +12 lines, -10 lines 1 comment Download
M mojo/edk/system/waiter_test_utils.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M mojo/edk/system/waiter_unittest.cc View 22 chunks +65 lines, -27 lines 0 comments Download

Depends on Patchset:

Issue 2076263003 Patch 1

Messages

Total messages: 4 (1 generated)
viettrungluu
4 years, 6 months ago (2016-06-18 00:17:12 UTC) #1
vardhan
lgtm https://codereview.chromium.org/2075353002/diff/1/mojo/edk/system/waiter.cc File mojo/edk/system/waiter.cc (left): https://codereview.chromium.org/2075353002/diff/1/mojo/edk/system/waiter.cc#oldcode34 mojo/edk/system/waiter.cc:34: // of |awake_result_| (except the first one in ...
4 years, 6 months ago (2016-06-21 07:49:01 UTC) #2
viettrungluu
4 years, 6 months ago (2016-06-21 15:33:54 UTC) #4
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
ac1b628f7867016f33edb467ec0c525bf2254aa1 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698