src/ast.cc - Issue 207613005: No longer OOM on invalid string length.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/ast.cc

Issue 207613005: No longer OOM on invalid string length. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/ast.cc

diff --git a/src/ast.cc b/src/ast.cc

index 086d0153623dd4b33c3749f424f4dfdc46c7b56d..449fe4a111d66a322ae766c95aa09d5625aa8bc3 100644

--- a/src/ast.cc

+++ b/src/ast.cc

@@ -1178,7 +1178,8 @@ Handle<String> Literal::ToString() {

} else {

str = DoubleToCString(value_->Number(), buffer);

}

- return isolate_->factory()->NewStringFromAscii(CStrVector(str));

+ Handle<String> res = isolate_->factory()->NewStringFromAscii(CStrVector(str));

+ return res;

Igor Sheludko 2014/03/24 13:43:16 As the allocation size is small and you are not go

}