Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(78)

Side by Side Diff: src/ast.cc

Issue 207613005: No longer OOM on invalid string length. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 1160 matching lines...) Expand 10 before | Expand all | Expand 10 after
1171 char arr[100]; 1171 char arr[100];
1172 Vector<char> buffer(arr, ARRAY_SIZE(arr)); 1172 Vector<char> buffer(arr, ARRAY_SIZE(arr));
1173 const char* str; 1173 const char* str;
1174 if (value_->IsSmi()) { 1174 if (value_->IsSmi()) {
1175 // Optimization only, the heap number case would subsume this. 1175 // Optimization only, the heap number case would subsume this.
1176 OS::SNPrintF(buffer, "%d", Smi::cast(*value_)->value()); 1176 OS::SNPrintF(buffer, "%d", Smi::cast(*value_)->value());
1177 str = arr; 1177 str = arr;
1178 } else { 1178 } else {
1179 str = DoubleToCString(value_->Number(), buffer); 1179 str = DoubleToCString(value_->Number(), buffer);
1180 } 1180 }
1181 return isolate_->factory()->NewStringFromAscii(CStrVector(str)); 1181 Handle<String> res = isolate_->factory()->NewStringFromAscii(CStrVector(str));
1182 return res;
Igor Sheludko 2014/03/24 13:43:16 As the allocation size is small and you are not go
1182 } 1183 }
1183 1184
1184 1185
1185 } } // namespace v8::internal 1186 } } // namespace v8::internal
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698