Cleanup: Remove NOTIFICATION_EXTENSION_UNLOADED usage in MediaScanManager.

Cleanup: Remove NOTIFICATION_EXTENSION_UNLOADED usage in MediaScanManager.

BUG=354046
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=262295

[not at google - send to devlin, 2014-03-27 21:33:12]

lgtm

[Lei Zhang, 2014-03-27 22:58:14]

thakis: base OWNERS review please.

[Nico, 2014-03-27 23:01:29]

https://codereview.chromium.org/207613002/diff/60001/chrome/browser/media_gal...
File chrome/browser/media_galleries/media_scan_manager.cc (right):

https://codereview.chromium.org/207613002/diff/60001/chrome/browser/media_gal...
chrome/browser/media_galleries/media_scan_manager.cc:514:
scoped_extension_registry_observer_.RemoveAll();
Won't RemoveObserver() be called twice now? (Once here, once from the destructor
of ScopedObserver)

[Lei Zhang, 2014-03-27 23:07:04]

https://codereview.chromium.org/207613002/diff/60001/chrome/browser/media_gal...
File chrome/browser/media_galleries/media_scan_manager.cc (right):

https://codereview.chromium.org/207613002/diff/60001/chrome/browser/media_gal...
chrome/browser/media_galleries/media_scan_manager.cc:514:
scoped_extension_registry_observer_.RemoveAll();
On 2014/03/27 23:01:29, Nico wrote:
> Won't RemoveObserver() be called twice now? (Once here, once from the
destructor
> of ScopedObserver)

Yes, same as before with NotificationRegistrar.

[Nico, 2014-03-28 03:34:12]

https://codereview.chromium.org/207613002/diff/60001/base/scoped_observer.h
File base/scoped_observer.h (right):

https://codereview.chromium.org/207613002/diff/60001/base/scoped_observer.h#n...
base/scoped_observer.h:39: sources_[i]->RemoveObserver(observer_);
and you don't think it's better to do a sources_.clear() after this? Else,
calling Remove() for each source will be different from calling RemoveAll, which
seems weird.

[Lei Zhang, 2014-03-28 03:40:55]

https://codereview.chromium.org/207613002/diff/60001/base/scoped_observer.h
File base/scoped_observer.h (right):

https://codereview.chromium.org/207613002/diff/60001/base/scoped_observer.h#n...
base/scoped_observer.h:39: sources_[i]->RemoveObserver(observer_);
On 2014/03/28 03:34:12, Nico wrote:
> and you don't think it's better to do a sources_.clear() after this? Else,
> calling Remove() for each source will be different from calling RemoveAll,
which
> seems weird.

Good catch. Thanks.

[Nico, 2014-03-28 03:42:11]

lgtm

[Lei Zhang, 2014-03-28 03:43:04]

The CQ bit was checked by thestig@chromium.org

[commit-bot: I haz the power, 2014-03-28 03:43:34]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/thestig@chromium.org/207613002/80001

[commit-bot: I haz the power, 2014-03-28 04:40:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-03-28 04:40:42]

Retried try job too often on win_rel for step(s) base_unittests, browser_tests,
interactive_ui_tests, net_unittests, unit_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[Lei Zhang, 2014-03-28 06:36:33]

The CQ bit was checked by thestig@chromium.org

[commit-bot: I haz the power, 2014-03-28 06:37:58]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/thestig@chromium.org/207613002/100001

[commit-bot: I haz the power, 2014-03-28 11:22:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-03-28 11:22:01]

Retried try job too often on ios_dbg_simulator for step(s) crypto_unittests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=ios_dbg_si...

[Lei Zhang, 2014-03-28 20:59:19]

The CQ bit was checked by thestig@chromium.org

[commit-bot: I haz the power, 2014-03-28 21:01:08]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/thestig@chromium.org/207613002/100001

[commit-bot: I haz the power, 2014-03-28 23:44:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-03-28 23:44:38]

Commit queue rejected this change because the description was changed
between the time the change entered the commit queue and the time it
was ready to commit. You can safely check the commit box again.

[Lei Zhang, 2014-04-01 21:04:23]

The CQ bit was checked by thestig@chromium.org

[commit-bot: I haz the power, 2014-04-01 21:05:24]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/thestig@chromium.org/207613002/100001

[commit-bot: I haz the power, 2014-04-01 21:05:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-04-01 21:05:31]

Failed to apply patch for
chrome/browser/extensions/api/media_galleries_private/gallery_watch_state_tracker.cc:
While running patch -p0 --forward --force --no-backup-if-mismatch;
  patching file
chrome/browser/extensions/api/media_galleries_private/gallery_watch_state_tracker.cc
  Hunk #1 FAILED at 191.
  Hunk #2 succeeded at 205 with fuzz 2.
  1 out of 2 hunks FAILED -- saving rejects to file
chrome/browser/extensions/api/media_galleries_private/gallery_watch_state_tracker.cc.rej

Patch:      
chrome/browser/extensions/api/media_galleries_private/gallery_watch_state_tracker.cc
Index:
chrome/browser/extensions/api/media_galleries_private/gallery_watch_state_tracker.cc
===================================================================
---
chrome/browser/extensions/api/media_galleries_private/gallery_watch_state_tracker.cc	(revision
259942)
+++
chrome/browser/extensions/api/media_galleries_private/gallery_watch_state_tracker.cc	(working
copy)
@@ -191,7 +191,9 @@
   WriteToStorage(extension_id);
 }
 
-void GalleryWatchStateTracker::OnExtensionLoaded(const Extension* extension) {
+void GalleryWatchStateTracker::OnExtensionLoaded(
+    content::BrowserContext* browser_context,
+    const Extension* extension) {
   DCHECK(content::BrowserThread::CurrentlyOn(content::BrowserThread::UI));
   StateStore* storage = ExtensionSystem::Get(profile_)->state_store();
   if (!storage)
@@ -205,6 +207,7 @@
 }
 
 void GalleryWatchStateTracker::OnExtensionUnloaded(
+    content::BrowserContext* browser_context,
     const Extension* extension) {
   DCHECK(content::BrowserThread::CurrentlyOn(content::BrowserThread::UI));
   if (!ContainsKey(watched_extensions_map_, extension->id()))

[Lei Zhang, 2014-04-01 21:08:45]

The CQ bit was checked by thestig@chromium.org

[commit-bot: I haz the power, 2014-04-01 21:09:31]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/thestig@chromium.org/207613002/120001

[commit-bot: I haz the power, 2014-04-01 22:53:35]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/thestig@chromium.org/207613002/120001

[commit-bot: I haz the power, 2014-04-01 23:05:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-04-01 23:05:55]

Try jobs failed on following builders:
  tryserver.chromium on mac_chromium_compile_dbg

[Lei Zhang, 2014-04-07 19:14:35]

The CQ bit was checked by thestig@chromium.org

[commit-bot: I haz the power, 2014-04-07 19:14:40]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/thestig@chromium.org/207613002/120001

[commit-bot: I haz the power, 2014-04-07 20:29:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-04-07 20:29:37]

Retried try job too often on android_clang_dbg for step(s) slave_steps
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android_cl...

Try jobs failed on following builders:
  tryserver.chromium on linux_chromium_rel

[Lei Zhang, 2014-04-07 21:58:43]

The CQ bit was checked by thestig@chromium.org

[commit-bot: I haz the power, 2014-04-07 21:59:23]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/thestig@chromium.org/207613002/140001

[commit-bot: I haz the power, 2014-04-08 04:01:13]

Change committed as 262295