Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(89)

Unified Diff: extensions/browser/extension_registry_unittest.cc

Issue 207613002: Cleanup: Remove NOTIFICATION_EXTENSION_UNLOADED usage in MediaScanManager. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: rebase, add error console Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « extensions/browser/extension_registry_observer.h ('k') | extensions/browser/runtime_data.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: extensions/browser/extension_registry_unittest.cc
===================================================================
--- extensions/browser/extension_registry_unittest.cc (revision 260931)
+++ extensions/browser/extension_registry_unittest.cc (working copy)
@@ -43,11 +43,13 @@
const ExtensionList& unloaded() { return unloaded_; }
private:
- virtual void OnExtensionLoaded(const Extension* extension) OVERRIDE {
+ virtual void OnExtensionLoaded(content::BrowserContext* browser_context,
+ const Extension* extension) OVERRIDE {
loaded_.push_back(extension);
}
- virtual void OnExtensionUnloaded(const Extension* extension) OVERRIDE {
+ virtual void OnExtensionUnloaded(content::BrowserContext* browser_context,
+ const Extension* extension) OVERRIDE {
unloaded_.push_back(extension);
}
@@ -56,7 +58,7 @@
};
TEST_F(ExtensionRegistryTest, FillAndClearRegistry) {
- ExtensionRegistry registry;
+ ExtensionRegistry registry(NULL);
scoped_refptr<Extension> extension1 = test_util::CreateExtensionWithID("id1");
scoped_refptr<Extension> extension2 = test_util::CreateExtensionWithID("id2");
scoped_refptr<Extension> extension3 = test_util::CreateExtensionWithID("id3");
@@ -90,7 +92,7 @@
// A simple test of adding and removing things from sets.
TEST_F(ExtensionRegistryTest, AddAndRemoveExtensionFromRegistry) {
- ExtensionRegistry registry;
+ ExtensionRegistry registry(NULL);
// Adding an extension works.
scoped_refptr<Extension> extension = test_util::CreateExtensionWithID("id");
@@ -111,7 +113,7 @@
}
TEST_F(ExtensionRegistryTest, AddExtensionToRegistryTwice) {
- ExtensionRegistry registry;
+ ExtensionRegistry registry(NULL);
scoped_refptr<Extension> extension = test_util::CreateExtensionWithID("id");
// An extension can exist in two sets at once. It would be nice to eliminate
@@ -126,7 +128,7 @@
}
TEST_F(ExtensionRegistryTest, GetExtensionById) {
- ExtensionRegistry registry;
+ ExtensionRegistry registry(NULL);
// Trying to get an extension fails cleanly when the sets are empty.
EXPECT_FALSE(
@@ -205,7 +207,7 @@
}
TEST_F(ExtensionRegistryTest, Observer) {
- ExtensionRegistry registry;
+ ExtensionRegistry registry(NULL);
TestObserver observer;
registry.AddObserver(&observer);
« no previous file with comments | « extensions/browser/extension_registry_observer.h ('k') | extensions/browser/runtime_data.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698