chrome/browser/ui/cocoa/extensions/toolbar_actions_bar_bubble_mac.mm - Issue 2076093004: [Extensions UI] Handle multiple warning bubbles racing to show

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/extensions/toolbar_actions_bar_bubble_mac.mm

Issue 2076093004: [Extensions UI] Handle multiple warning bubbles racing to show (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix win tests Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/cocoa/extensions/extension_message_bubble_browsertest_mac.mm ('k') | chrome/browser/ui/extensions/extension_message_bubble_browsertest.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/extensions/toolbar_actions_bar_bubble_mac.mm

diff --git a/chrome/browser/ui/cocoa/extensions/toolbar_actions_bar_bubble_mac.mm b/chrome/browser/ui/cocoa/extensions/toolbar_actions_bar_bubble_mac.mm

index 014f5c0d844ad36c0b54b41c45c899b6df0b9968..12e764ff5fe88632829e183c0dfded575b19f53e 100644

--- a/chrome/browser/ui/cocoa/extensions/toolbar_actions_bar_bubble_mac.mm

+++ b/chrome/browser/ui/cocoa/extensions/toolbar_actions_bar_bubble_mac.mm

@@ -117,6 +117,10 @@ CGFloat kMinWidth = 320.0;

ToolbarActionsBarBubbleDelegate::CLOSE_DISMISS_DEACTIVATION);

acknowledged_ = YES;

}

+ // Deallocation happens asynchronously in Cocoa, but that makes testing

+ // difficult. Explicitly destroy |delegate_| here so it can perform any

+ // necessary cleanup.

+ delegate_.reset();

[super windowWillClose:notification];

}