Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(303)

Unified Diff: chrome/browser/ui/cocoa/extensions/extension_message_bubble_browsertest_mac.mm

Issue 2076093004: [Extensions UI] Handle multiple warning bubbles racing to show (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix win tests Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/cocoa/extensions/extension_message_bubble_browsertest_mac.mm
diff --git a/chrome/browser/ui/cocoa/extensions/extension_message_bubble_browsertest_mac.mm b/chrome/browser/ui/cocoa/extensions/extension_message_bubble_browsertest_mac.mm
index e7dd1a813be14848bf3cae7baa4d26a3422f0755..83cd862987e79bd56c54eea5c9db314031de0373 100644
--- a/chrome/browser/ui/cocoa/extensions/extension_message_bubble_browsertest_mac.mm
+++ b/chrome/browser/ui/cocoa/extensions/extension_message_bubble_browsertest_mac.mm
@@ -74,9 +74,9 @@ class ExtensionMessageBubbleBrowserTestMac
private:
void SetUpCommandLine(base::CommandLine* command_line) override;
- void CheckBubble(Browser* browser, AnchorPosition anchor) override;
- void CloseBubble(Browser* browser) override;
- void CheckBubbleIsNotPresent(Browser* browser) override;
+ void CheckBubbleNative(Browser* browser, AnchorPosition anchor) override;
+ void CloseBubbleNative(Browser* browser) override;
+ void CheckBubbleIsNotPresentNative(Browser* browser) override;
DISALLOW_COPY_AND_ASSIGN(ExtensionMessageBubbleBrowserTestMac);
};
@@ -87,7 +87,7 @@ void ExtensionMessageBubbleBrowserTestMac::SetUpCommandLine(
[ToolbarActionsBarBubbleMac setAnimationEnabledForTesting:NO];
}
-void ExtensionMessageBubbleBrowserTestMac::CheckBubble(
+void ExtensionMessageBubbleBrowserTestMac::CheckBubbleNative(
Browser* browser,
AnchorPosition anchor) {
ToolbarController* toolbarController = ToolbarControllerForBrowser(browser);
@@ -106,7 +106,7 @@ void ExtensionMessageBubbleBrowserTestMac::CheckBubble(
CheckBubbleAndReferenceView(bubble, anchorView);
}
-void ExtensionMessageBubbleBrowserTestMac::CloseBubble(Browser* browser) {
+void ExtensionMessageBubbleBrowserTestMac::CloseBubbleNative(Browser* browser) {
BrowserActionsController* controller =
[ToolbarControllerForBrowser(browser) browserActionsController];
ToolbarActionsBarBubbleMac* bubble = [controller activeBubble];
@@ -115,7 +115,7 @@ void ExtensionMessageBubbleBrowserTestMac::CloseBubble(Browser* browser) {
EXPECT_EQ(nil, [controller activeBubble]);
}
-void ExtensionMessageBubbleBrowserTestMac::CheckBubbleIsNotPresent(
+void ExtensionMessageBubbleBrowserTestMac::CheckBubbleIsNotPresentNative(
Browser* browser) {
EXPECT_EQ(
nil,
@@ -157,3 +157,8 @@ IN_PROC_BROWSER_TEST_F(ExtensionMessageBubbleBrowserTestMac,
TestDevModeBubbleIsntShownTwice) {
TestDevModeBubbleIsntShownTwice();
}
+
+IN_PROC_BROWSER_TEST_F(ExtensionMessageBubbleBrowserTestMac,
+ TestBubbleWithMultipleWindows) {
+ TestBubbleWithMultipleWindows();
+}

Powered by Google App Engine
This is Rietveld 408576698