Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Issue 2076083002: [snapshot] support including templates in the snapshot. (Closed)

Created:
4 years, 6 months ago by Yang
Modified:
4 years, 6 months ago
CC:
Hannes Payer (out of office), Paweł Hajdan Jr., ulan, v8-reviews_googlegroups.com, Yang
Base URL:
https://chromium.googlesource.com/v8/v8.git@externalref
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[snapshot] support including templates in the snapshot. R=jochen@chromium.org, verwaest@chromium.org BUG=chromium:617892 Committed: https://crrev.com/c5ae5bb16ba7c1c767f6920df7f22b6e6a4c8f6a Cr-Commit-Position: refs/heads/master@{#37122}

Patch Set 1 #

Patch Set 2 : fix build #

Unified diffs Side-by-side diffs Delta from patch set Stats (+111 lines, -5 lines) Patch
M include/v8.h View 1 3 chunks +12 lines, -0 lines 0 comments Download
M src/api.cc View 1 5 chunks +57 lines, -1 line 0 comments Download
M src/heap/heap.h View 2 chunks +4 lines, -1 line 0 comments Download
M src/heap/heap.cc View 1 2 chunks +3 lines, -0 lines 0 comments Download
M src/heap/heap-inl.h View 1 chunk +5 lines, -0 lines 0 comments Download
M src/snapshot/partial-serializer.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M test/cctest/test-serialize.cc View 1 3 chunks +28 lines, -3 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 12 (5 generated)
Yang
4 years, 6 months ago (2016-06-17 09:11:17 UTC) #1
jochen (gone - plz use gerrit)
lgtm
4 years, 6 months ago (2016-06-20 12:43:13 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2076083002/1
4 years, 6 months ago (2016-06-20 15:31:06 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux_mips64el_compile_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_mips64el_compile_rel/builds/16270) v8_linux_nodcheck_rel_ng on tryserver.v8 (JOB_FAILED, ...
4 years, 6 months ago (2016-06-20 15:33:39 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2076083002/20001
4 years, 6 months ago (2016-06-21 04:29:45 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 6 months ago (2016-06-21 05:08:46 UTC) #10
commit-bot: I haz the power
4 years, 6 months ago (2016-06-21 05:11:03 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/c5ae5bb16ba7c1c767f6920df7f22b6e6a4c8f6a
Cr-Commit-Position: refs/heads/master@{#37122}

Powered by Google App Engine
This is Rietveld 408576698