[snapshot] serialize embedder-provided external references.

[snapshot] serialize embedder-provided external references.

R=jochen@chromium.org, vogelheim@chromium.org
BUG=chromium:617892
Committed: https://crrev.com/0b177bc06cb1c2f6ea01d107f1cba5d810ade4d7
Cr-Commit-Position: refs/heads/master@{#37109}

[Yang, 2016-06-16 12:00:53]

The CQ bit was checked by yangguo@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-06-16 12:00:56]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2066993004/1

[commit-bot: I haz the power, 2016-06-16 12:29:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-16 12:29:22]

Dry run: This issue passed the CQ dry run.

[Yang, 2016-06-17 09:10:38]

The CQ bit was checked by yangguo@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-06-17 09:10:52]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2066993004/20001

[commit-bot: I haz the power, 2016-06-17 09:45:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-17 09:45:27]

Dry run: This issue passed the CQ dry run.

[jochen (gone - plz use gerrit), 2016-06-20 13:11:12]

lgtm with comment

https://codereview.chromium.org/2066993004/diff/20001/include/v8.h
File include/v8.h (right):

https://codereview.chromium.org/2066993004/diff/20001/include/v8.h#newcode5553
include/v8.h:5553: * Specifies an optional null-terminated array of raw
addresses in the
nullptr

https://codereview.chromium.org/2066993004/diff/20001/include/v8.h#newcode6791
include/v8.h:6791: SnapshotCreator(intptr_t* external_references = nullptr,
maybe make that the second parameter, so it's backward compatible?

[Yang, 2016-06-20 13:59:42]

On 2016/06/20 13:11:12, jochen wrote:
> lgtm with comment
> 
> https://codereview.chromium.org/2066993004/diff/20001/include/v8.h
> File include/v8.h (right):
> 
> https://codereview.chromium.org/2066993004/diff/20001/include/v8.h#newcode5553
> include/v8.h:5553: * Specifies an optional null-terminated array of raw
> addresses in the
> nullptr
> 
> https://codereview.chromium.org/2066993004/diff/20001/include/v8.h#newcode6791
> include/v8.h:6791: SnapshotCreator(intptr_t* external_references = nullptr,
> maybe make that the second parameter, so it's backward compatible?

I thought about that, but then again I'm fairly certain that nobody is using
this API yet. The snapshot blob argument should be unnecessary for most use
cases.

[Yang, 2016-06-20 13:59:49]

On 2016/06/20 13:11:12, jochen wrote:
> lgtm with comment
> 
> https://codereview.chromium.org/2066993004/diff/20001/include/v8.h
> File include/v8.h (right):
> 
> https://codereview.chromium.org/2066993004/diff/20001/include/v8.h#newcode5553
> include/v8.h:5553: * Specifies an optional null-terminated array of raw
> addresses in the
> nullptr
> 
> https://codereview.chromium.org/2066993004/diff/20001/include/v8.h#newcode6791
> include/v8.h:6791: SnapshotCreator(intptr_t* external_references = nullptr,
> maybe make that the second parameter, so it's backward compatible?

I thought about that, but then again I'm fairly certain that nobody is using
this API yet. The snapshot blob argument should be unnecessary for most use
cases.

[Yang, 2016-06-20 14:57:47]

The CQ bit was checked by yangguo@chromium.org

[Yang, 2016-06-20 14:57:47]

The patchset sent to the CQ was uploaded after l-g-t-m from jochen@chromium.org
Link to the patchset: https://codereview.chromium.org/2066993004/#ps40001
(title: "git cl set_commit")

[commit-bot: I haz the power, 2016-06-20 14:57:50]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2066993004/40001

[commit-bot: I haz the power, 2016-06-20 15:28:18]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-06-20 15:28:36]

Description was changed from

==========
[snapshot] serialize embedder-provided external references.

R=jochen@chromium.org, vogelheim@chromium.org
BUG=chromium:617892
==========

to

==========
[snapshot] serialize embedder-provided external references.

R=jochen@chromium.org, vogelheim@chromium.org
BUG=chromium:617892

Committed: https://crrev.com/0b177bc06cb1c2f6ea01d107f1cba5d810ade4d7
Cr-Commit-Position: refs/heads/master@{#37109}
==========

[commit-bot: I haz the power, 2016-06-20 15:28:37]

Patchset 3 (id:??) landed as
https://crrev.com/0b177bc06cb1c2f6ea01d107f1cba5d810ade4d7
Cr-Commit-Position: refs/heads/master@{#37109}