Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(965)

Unified Diff: content/public/browser/web_contents.h

Issue 2076063002: Clarify that WebContents::GetLastCommittedURL returns the virtual URL. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/public/browser/web_contents.h
diff --git a/content/public/browser/web_contents.h b/content/public/browser/web_contents.h
index 90b647efcbf43132033298205d9ce8a0837945d8..7474725b61227aeadc3587769150ab619239e2bf 100644
--- a/content/public/browser/web_contents.h
+++ b/content/public/browser/web_contents.h
@@ -210,9 +210,9 @@ class WebContents : public PageNavigator,
// page (active) but the security context is of the old page (last committed).
virtual const GURL& GetVisibleURL() const = 0;
- // Gets the last committed URL. It represents the current page that is
- // displayed in this WebContents. It represents the current security
- // context.
+ // Gets the last committed URL. This is the URL that would be displayed in the
Charlie Reis 2016/06/20 17:33:06 We probably want to be more explicit about the dif
dominickn 2016/06/20 23:56:06 Done.
+ // URL bar for the current page displayed in this WebContents. It represents
+ // the current security context.
virtual const GURL& GetLastCommittedURL() const = 0;
// Return the currently active RenderProcessHost and RenderViewHost. Each of
« content/public/browser/navigation_handle.h ('K') | « content/public/browser/navigation_handle.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698