Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(324)

Side by Side Diff: content/public/browser/web_contents.h

Issue 2076063002: Clarify that WebContents::GetLastCommittedURL returns the virtual URL. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CONTENT_PUBLIC_BROWSER_WEB_CONTENTS_H_ 5 #ifndef CONTENT_PUBLIC_BROWSER_WEB_CONTENTS_H_
6 #define CONTENT_PUBLIC_BROWSER_WEB_CONTENTS_H_ 6 #define CONTENT_PUBLIC_BROWSER_WEB_CONTENTS_H_
7 7
8 #include <stdint.h> 8 #include <stdint.h>
9 9
10 #include <set> 10 #include <set>
(...skipping 192 matching lines...) Expand 10 before | Expand all | Expand 10 after
203 // |GetLastCommittedURL| as appropriate. 203 // |GetLastCommittedURL| as appropriate.
204 virtual const GURL& GetURL() const = 0; 204 virtual const GURL& GetURL() const = 0;
205 205
206 // Gets the URL currently being displayed in the URL bar, if there is one. 206 // Gets the URL currently being displayed in the URL bar, if there is one.
207 // This URL might be a pending navigation that hasn't committed yet, so it is 207 // This URL might be a pending navigation that hasn't committed yet, so it is
208 // not guaranteed to match the current page in this WebContents. A typical 208 // not guaranteed to match the current page in this WebContents. A typical
209 // example of this is interstitials, which show the URL of the new/loading 209 // example of this is interstitials, which show the URL of the new/loading
210 // page (active) but the security context is of the old page (last committed). 210 // page (active) but the security context is of the old page (last committed).
211 virtual const GURL& GetVisibleURL() const = 0; 211 virtual const GURL& GetVisibleURL() const = 0;
212 212
213 // Gets the last committed URL. It represents the current page that is 213 // Gets the last committed URL. This is the URL that would be displayed in the
Charlie Reis 2016/06/20 17:33:06 We probably want to be more explicit about the dif
dominickn 2016/06/20 23:56:06 Done.
214 // displayed in this WebContents. It represents the current security 214 // URL bar for the current page displayed in this WebContents. It represents
215 // context. 215 // the current security context.
216 virtual const GURL& GetLastCommittedURL() const = 0; 216 virtual const GURL& GetLastCommittedURL() const = 0;
217 217
218 // Return the currently active RenderProcessHost and RenderViewHost. Each of 218 // Return the currently active RenderProcessHost and RenderViewHost. Each of
219 // these may change over time. 219 // these may change over time.
220 virtual RenderProcessHost* GetRenderProcessHost() const = 0; 220 virtual RenderProcessHost* GetRenderProcessHost() const = 0;
221 221
222 // Returns the main frame for the currently active view. 222 // Returns the main frame for the currently active view.
223 virtual RenderFrameHost* GetMainFrame() = 0; 223 virtual RenderFrameHost* GetMainFrame() = 0;
224 224
225 // Returns the focused frame for the currently active view. 225 // Returns the focused frame for the currently active view.
(...skipping 522 matching lines...) Expand 10 before | Expand all | Expand 10 after
748 748
749 private: 749 private:
750 // This interface should only be implemented inside content. 750 // This interface should only be implemented inside content.
751 friend class WebContentsImpl; 751 friend class WebContentsImpl;
752 WebContents() {} 752 WebContents() {}
753 }; 753 };
754 754
755 } // namespace content 755 } // namespace content
756 756
757 #endif // CONTENT_PUBLIC_BROWSER_WEB_CONTENTS_H_ 757 #endif // CONTENT_PUBLIC_BROWSER_WEB_CONTENTS_H_
OLDNEW
« content/public/browser/navigation_handle.h ('K') | « content/public/browser/navigation_handle.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698